[jboss-jira] [JBoss JIRA] Commented: (AS7-704) close container managed entity managers after servlet invocation completes (via WebNonTxEmCloserValve valve)

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/AS7-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601668#comment-12601668 ] 

Scott Marlow commented on AS7-704:
----------------------------------

The purpose of the JIRA wasn't tied to a specific implementation of solving the problem.

I did improve the valve actually.  The valve calls NonTxEmCloser.pushCall(), which creates a null collection in thread local storage, instead of an empty collection.  This will conserve memory as you requested.  The valve also calls NonTxEmCloser.popCall(), which will see the null collection and return (for most cases).  For the next level of efficiency, one of the JPA DUPs needs a way to dynamically register the valve with the web deployment (or something like that).  By default, I don't want to register the valve (99% of the cases I would expect).  Just because I didn't follow your exact plan for optimizing, doesn't mean there isn't "any" improvement.  My improvement will also help the EJB3.1 case as well.

We discussed having an EE thread-local map for stuff like this but as far as I know, that hasn't come in yet (I'm not sure how that would help register valves at deployment time).  I assume you will have an unordered collection of valve classes (by class object not class name), to be invoked.  If you make such a collection available, I'll add the WebNonTxEmCloserValve class to it.



> close container managed entity managers after servlet invocation completes (via WebNonTxEmCloserValve valve)
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-704
>                 URL: https://issues.jboss.org/browse/AS7-704
>             Project: Application Server 7
>          Issue Type: Sub-task
>          Components: Web
>            Reporter: Scott Marlow
>            Assignee: Remy Maucherat
>             Fix For: 7.0.0.CR1
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira