[jboss-jira] [JBoss JIRA] (JBJCA-699) Duplicated class definitions shouldn't be allowed

[Jesper Pedersen (Updated) (JIRA)]

     [ https://issues.jboss.org/browse/JBJCA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesper Pedersen updated JBJCA-699:
----------------------------------

        Summary: Duplicated class definitions shouldn't be allowed  (was: Wrong generated code - " AResourceAdapter must implement the javax.resource.spi.ResourceAdapter interface")
     Issue Type: Feature Request  (was: Bug)
    Description: 
The code generator allows the same class name to be entered multiple times:

{code}
marti-pc:codegenerator pjuza$ sh ./codegenerator.sh
Profile version (1.6/1.5/1.0) [1.6]: 1.5
Type (O/Outbound/I/Inbound/B/Bidirectional) [O]: 
Package name: com.cleverlance.smartclient.ra.httpclient
Transaction support (N/NoTransaction/L/LocalTransaction/X/XATransaction) [N]: 
Support reauthentication (Y/Yes/N/No) [N]: 
Include a ResourceAdapter (Y/Yes/N/No) [Y]: 
Resource adapter class name [AcmeResourceAdapter]: HttpClientResourceAdapterImpl
Resource adapter config properties [enter to quit]: 
    Name: 
Managed connection factory class name [AcmeManagedConnectionFactory]: HttpClientResourceAdapterImpl
Managed connection factory config properties [enter to quit]: 
    Name: 
Use ResourceAdapterAssociation (Y/Yes/N/No) [Y]: 
Managed connection class name [AcmeManagedConnection]: HttpClientManagedConnectionImpl
Use CCI (Y/Yes/N/No) [N]: 
Connection factory interface class name [AcmeConnectionFactory]: HttpClientRaConnectionFactory
Connection factory implementation class name [AcmeConnectionFactoryImpl]: HttpClientRaConnectionFactoryImpl
Connection interface class name [AcmeConnection]: ManagedClientConnection
Connection implementation class name [AcmeConnectionImpl]: ManagedClientConnectionImpl
Add methods to connection interface (Y/Yes/N/No) [N]: 
Additional managed connection factory (Y/Yes/N/No) [N]: 
Include an admin object (Y/Yes/N/No) [N]: 
Generate a MBean class (Y/Yes/N/No) [Y]: 
Build environment [A/Ant/I/Ant+Ivy/M/Maven] [A]: M
Code generated
{code}


  was:
Wrong generated RA classes with the following configuration:

marti-pc:codegenerator pjuza$ sh ./codegenerator.sh
Profile version (1.6/1.5/1.0) [1.6]: 1.5
Type (O/Outbound/I/Inbound/B/Bidirectional) [O]: 
Package name: com.cleverlance.smartclient.ra.httpclient
Transaction support (N/NoTransaction/L/LocalTransaction/X/XATransaction) [N]: 
Support reauthentication (Y/Yes/N/No) [N]: 
Include a ResourceAdapter (Y/Yes/N/No) [Y]: 
Resource adapter class name [AcmeResourceAdapter]: HttpClientResourceAdapterImpl
Resource adapter config properties [enter to quit]: 
    Name: 
Managed connection factory class name [AcmeManagedConnectionFactory]: HttpClientResourceAdapterImpl
Managed connection factory config properties [enter to quit]: 
    Name: 
Use ResourceAdapterAssociation (Y/Yes/N/No) [Y]: 
Managed connection class name [AcmeManagedConnection]: HttpClientManagedConnectionImpl
Use CCI (Y/Yes/N/No) [N]: 
Connection factory interface class name [AcmeConnectionFactory]: HttpClientRaConnectionFactory
Connection factory implementation class name [AcmeConnectionFactoryImpl]: HttpClientRaConnectionFactoryImpl
Connection interface class name [AcmeConnection]: ManagedClientConnection
Connection implementation class name [AcmeConnectionImpl]: ManagedClientConnectionImpl
Add methods to connection interface (Y/Yes/N/No) [N]: 
Additional managed connection factory (Y/Yes/N/No) [N]: 
Include an admin object (Y/Yes/N/No) [N]: 
Generate a MBean class (Y/Yes/N/No) [Y]: 
Build environment [A/Ant/I/Ant+Ivy/M/Maven] [A]: M
Code generated 

When you run test you get this error:
org.jboss.arquillian.container.spi.client.container.DeploymentException: Could not deploy the application: IJ020056: Deployment failed: file:/C:/Users/PETRJU~1/AppData/Local/Temp/ConnectorTestCase.rar
	at org.jboss.jca.embedded.arquillian.EmbeddedJCAContainer.deploy(EmbeddedJCAContainer.java:150)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$3.call(ContainerDeployController.java:148)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$3.call(ContainerDeployController.java:115)
...
Caused by: org.jboss.jca.validator.ValidatorException: Severity: ERROR
Section: 5.3.1
Description: A ResourceAdapter must implement the javax.resource.spi.ResourceAdapter interface.
Code: com.cleverlance.smartclient.ra.httpclient.HttpClientResourceAdapterImpl
	at org.jboss.jca.deployers.common.AbstractResourceAdapterDeployer.createObjectsAn



       Assignee: Jeff Zhang  (was: Jesper Pedersen)


If the same class name is entered multiple times - the question should be repeated.
                
> Duplicated class definitions shouldn't be allowed
> -------------------------------------------------
>
>                 Key: JBJCA-699
>                 URL: https://issues.jboss.org/browse/JBJCA-699
>             Project: IronJacamar
>          Issue Type: Feature Request
>          Components: Code Generator
>    Affects Versions: 1.1.0.Alpha3
>         Environment: MacOS 10.6.8
>            Reporter: Petr Juza
>            Assignee: Jeff Zhang
>            Priority: Minor
>
> The code generator allows the same class name to be entered multiple times:
> {code}
> marti-pc:codegenerator pjuza$ sh ./codegenerator.sh
> Profile version (1.6/1.5/1.0) [1.6]: 1.5
> Type (O/Outbound/I/Inbound/B/Bidirectional) [O]: 
> Package name: com.cleverlance.smartclient.ra.httpclient
> Transaction support (N/NoTransaction/L/LocalTransaction/X/XATransaction) [N]: 
> Support reauthentication (Y/Yes/N/No) [N]: 
> Include a ResourceAdapter (Y/Yes/N/No) [Y]: 
> Resource adapter class name [AcmeResourceAdapter]: HttpClientResourceAdapterImpl
> Resource adapter config properties [enter to quit]: 
>     Name: 
> Managed connection factory class name [AcmeManagedConnectionFactory]: HttpClientResourceAdapterImpl
> Managed connection factory config properties [enter to quit]: 
>     Name: 
> Use ResourceAdapterAssociation (Y/Yes/N/No) [Y]: 
> Managed connection class name [AcmeManagedConnection]: HttpClientManagedConnectionImpl
> Use CCI (Y/Yes/N/No) [N]: 
> Connection factory interface class name [AcmeConnectionFactory]: HttpClientRaConnectionFactory
> Connection factory implementation class name [AcmeConnectionFactoryImpl]: HttpClientRaConnectionFactoryImpl
> Connection interface class name [AcmeConnection]: ManagedClientConnection
> Connection implementation class name [AcmeConnectionImpl]: ManagedClientConnectionImpl
> Add methods to connection interface (Y/Yes/N/No) [N]: 
> Additional managed connection factory (Y/Yes/N/No) [N]: 
> Include an admin object (Y/Yes/N/No) [N]: 
> Generate a MBean class (Y/Yes/N/No) [Y]: 
> Build environment [A/Ant/I/Ant+Ivy/M/Maven] [A]: M
> Code generated
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira