[jboss-jira] [JBoss JIRA] (AS7-2649) Add support for ConnectionFactory.newInstance() usage

[Thomas Diesler (Issue Comment Edited) (JIRA)]

    [ https://issues.jboss.org/browse/AS7-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643130#comment-12643130 ] 

Thomas Diesler edited comment on AS7-2649 at 11/15/11 6:45 PM:
---------------------------------------------------------------

I'm reluctant to require the client of this API to add a jboss-modules dependency in the manifest. It would be equally wrong to generate a hard dependency on apache scout in a DUP. 

A possible solution would be to generate a dependency on an intermediary module (i.e. org.jboss.jaxr.provider) which reexports the impl and such provides a configurable indirection layer.

Another option would be to add the value of the generated dependency as a config option to the jaxr subsystem.  
                
      was (Author: thomas.diesler):
    I'm reluctant to require the client of this API to add a jboss-modules dependency in the manifest. It would be equally wrong to generate a hard dependency on apache scout in a DUP. 

A possible solution would be to generate a dependency on an intermediary module (i.e. org.jboss.jaxr.provider) which reexports the impl and such provides a configurable indirection layer.

Another option would be to add the value of the generated dependency as a cofig option to the jaxr subsystem.  
                  
> Add support for ConnectionFactory.newInstance() usage
> -----------------------------------------------------
>
>                 Key: AS7-2649
>                 URL: https://issues.jboss.org/browse/AS7-2649
>             Project: Application Server 7
>          Issue Type: Task
>          Components: JAXR
>            Reporter: Thomas Diesler
>            Assignee: Thomas Diesler
>
> The TCK checks support for ConnectionFactory.newInstance(). The current implementation inthe jaxr api modules is 
> {code}
>    public static ConnectionFactory newInstance() throws JAXRException
>    {
>       String factoryName = null;
>       ConnectionFactory factory = null;
>       try
>       {
>          String defaultName = null;
>          factoryName = System.getProperty(SYS_PROP_NAME, defaultName);
>          ClassLoader loader = Thread.currentThread().getContextClassLoader();
>          Class factoryClass = loader.loadClass(factoryName);
>          factory = (ConnectionFactory) factoryClass.newInstance();
>       }
>       catch(Throwable e)
>       {
>          throw new JAXRException("Failed to create instance of: "+factoryName, e);
>       }
>       return factory;
>    }
> {code}
> This means that the system property would have to be set and that the user of this API actually has a dependency on the module that provides the implementation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira