[jboss-jira] [JBoss JIRA] (JGRP-1337) ConnectionMap: getConnection() can be a bottleneck

[Bela Ban (Resolved) (JIRA)]

     [ https://issues.jboss.org/browse/JGRP-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bela Ban resolved JGRP-1337.
----------------------------

    Resolution: Won't Fix


Cannot do this, as this code might get executed concurrently, so we cannot move connecting to the destination out of the lock scope.
Not super important, as we'll rewrite the TCP transport anyway in 3.2
                
> ConnectionMap: getConnection() can be a bottleneck
> --------------------------------------------------
>
>                 Key: JGRP-1337
>                 URL: https://issues.jboss.org/browse/JGRP-1337
>             Project: JGroups
>          Issue Type: Enhancement
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>            Priority: Minor
>             Fix For: 3.1
>
>
> When multiple threads call TcpConnectionMap.Mapper.getConnection() to different target addresses, and some of those addresses are down, then the threads unnecessarily compete for the same lock, therefore socket creations to targets which are up might get delayed by socket creations to targets which are down.
> SOLUTION: move the actual creation of a socket out of the lock scope
> NOTE: getConnection() may not even need to acquire the lock as the calling code already acquired it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira