[jboss-jira] [JBoss JIRA] (JGRP-1328) LockService and ExecutionService may drop a message if the coordinator goes down while trying to send a request
Bela Ban (Commented) (JIRA)
jira-events at lists.jboss.org
Wed Nov 16 07:44:41 EST 2011
[ https://issues.jboss.org/browse/JGRP-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643315#comment-12643315 ]
Bela Ban commented on JGRP-1328:
--------------------------------
This is not an issue in PEER_LOCK (handleView()):
[code]
// For all non-acquired client locks, send the GRANT_LOCK request to the new coordinator (if changed)
if(old_coord != null && !old_coord.equals(coord)) {
Map<String,Map<Owner,ClientLock>> copy;
synchronized(client_locks) {
copy=new HashMap<String,Map<Owner,ClientLock>>(client_locks);
}
if(!copy.isEmpty()) {
for(Map<Owner,ClientLock> map: copy.values()) {
for(ClientLock lock: map.values()) {
if(!lock.acquired && !lock.denied)
sendGrantLockRequest(lock.name, lock.owner, lock.timeout, lock.is_trylock);
}
}
}
}
}
[/code]
On a view change that excludes the current coordinator, this code re-submits *pending* lock requests to the new coordinator
> LockService and ExecutionService may drop a message if the coordinator goes down while trying to send a request
> ---------------------------------------------------------------------------------------------------------------
>
> Key: JGRP-1328
> URL: https://issues.jboss.org/browse/JGRP-1328
> Project: JGroups
> Issue Type: Bug
> Reporter: William Burns
> Assignee: Bela Ban
> Fix For: 3.1
>
>
> I was talking with Bela in regards to this and am not sure if this is an issue or not. It may be that the view change will block the msg, but there is still no way the Service knows to now resend to the new coordinator as it is trying to send to the now down coordinator. This is just here to not forget about the issue and so we can revisit it at a later time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jboss-jira
mailing list