[jboss-jira] [JBoss JIRA] (AS7-2771) ModelControllerClient operations don't fail on invalid username/password

[Thomas Diesler (Updated) (JIRA)]

     [ https://issues.jboss.org/browse/AS7-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Diesler updated AS7-2771:
--------------------------------

        Summary: ModelControllerClient operations don't fail on invalid username/password  (was: ModelControllerClient operations don't fail on invalud username/password)
    Description: 
Running org.jboss.as.test.smoke.jsr88.EnterpriseDeploymentTestCase
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 128.98 sec

There should be a test failure with this

{code}
    @Test
    public void testListAvailableModulesUnauthorized() throws Exception {
        DeploymentManager manager = getDeploymentManager("nobody", "nopass");
        Target[] targets = manager.getTargets();
        // [TODO] This should fail already
        TargetModuleID[] availableModules = manager.getAvailableModules(ModuleType.EAR, targets);
        assertNull(availableModules);

        ProgressObject progress = jsr88Deploy(manager, getEarArchive());
        TargetModuleID[] targetModules = progress.getResultTargetModuleIDs();
        try {
            availableModules = manager.getAvailableModules(ModuleType.EAR, targets);
            assertNotNull(availableModules);
            assertEquals(1, availableModules.length);

            TargetModuleID targetModuleID = availableModules[0];
            String moduleID = targetModuleID.getModuleID();
            assertTrue("Ends with deployment-app.ear", moduleID.endsWith("deployment-app.ear"));

            // [TODO] verify child modules

        } finally {
            jsr88Undeploy(manager, targetModules);
        }
    }
{code}


  was:

Running org.jboss.as.test.smoke.jsr88.EnterpriseDeploymentTestCase
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 128.98 sec

There should be a test failure with this

{code}
    @Test
    public void testListAvailableModulesUnauthorized() throws Exception {
        DeploymentManager manager = getDeploymentManager("nobody", "nopass");
        Target[] targets = manager.getTargets();
        // [TODO] This should fail already
        TargetModuleID[] availableModules = manager.getAvailableModules(ModuleType.EAR, targets);
        assertNull(availableModules);

        ProgressObject progress = jsr88Deploy(manager, getEarArchive());
        TargetModuleID[] targetModules = progress.getResultTargetModuleIDs();
        try {
            availableModules = manager.getAvailableModules(ModuleType.EAR, targets);
            assertNotNull(availableModules);
            assertEquals(1, availableModules.length);

            TargetModuleID targetModuleID = availableModules[0];
            String moduleID = targetModuleID.getModuleID();
            assertTrue("Ends with deployment-app.ear", moduleID.endsWith("deployment-app.ear"));

            // [TODO] verify child modules

        } finally {
            jsr88Undeploy(manager, targetModules);
        }
    }
{code}



    
> ModelControllerClient operations don't fail on invalid username/password
> ------------------------------------------------------------------------
>
>                 Key: AS7-2771
>                 URL: https://issues.jboss.org/browse/AS7-2771
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Domain Management, JSR-88
>            Reporter: Thomas Diesler
>            Assignee: Darran Lofthouse
>            Priority: Critical
>
> Running org.jboss.as.test.smoke.jsr88.EnterpriseDeploymentTestCase
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 128.98 sec
> There should be a test failure with this
> {code}
>     @Test
>     public void testListAvailableModulesUnauthorized() throws Exception {
>         DeploymentManager manager = getDeploymentManager("nobody", "nopass");
>         Target[] targets = manager.getTargets();
>         // [TODO] This should fail already
>         TargetModuleID[] availableModules = manager.getAvailableModules(ModuleType.EAR, targets);
>         assertNull(availableModules);
>         ProgressObject progress = jsr88Deploy(manager, getEarArchive());
>         TargetModuleID[] targetModules = progress.getResultTargetModuleIDs();
>         try {
>             availableModules = manager.getAvailableModules(ModuleType.EAR, targets);
>             assertNotNull(availableModules);
>             assertEquals(1, availableModules.length);
>             TargetModuleID targetModuleID = availableModules[0];
>             String moduleID = targetModuleID.getModuleID();
>             assertTrue("Ends with deployment-app.ear", moduleID.endsWith("deployment-app.ear"));
>             // [TODO] verify child modules
>         } finally {
>             jsr88Undeploy(manager, targetModules);
>         }
>     }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira