[jboss-jira] [JBoss JIRA] Commented: (AS7-1994) access to the ModelNodeRegistration during handling of an operation and during deployment

[Stefano Maestri (JIRA)]

    [ https://issues.jboss.org/browse/AS7-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631863#comment-12631863 ] 

Stefano Maestri commented on AS7-1994:
--------------------------------------

Hi all,

I'm reporting here a discussion I had with Emanuel regarding this issue and the implementation of JCA metrics. During the discussion I've recalled also the original discussion, and our needs.
I'm sending this email mainly as reminder for me to discuss these points with Brian after his and mine vacations

regard
S.

* pferraro_ (~pferraro at adsl-99-97-30-7.dsl.wlfrct.sbcglobal.net) has joined #jboss-as7
<emuckenhuber_> maeste: pong
* emuckenhuber_ is now known as emuckenhuber
<maeste> emuckenhuber_: Hi, I'm trying to implement our metrics. Just to recall we need this issue Brian has resolved to implement them: AS7-772
<jbossbot> jira [AS7-772] Allow operation handlers to register child ModelNodeRegistrations [Resolved (Done) Feature Request, Critical, Brian Stansberry] https://issues.jboss.org/browse/AS7-772
<maeste> emuckenhuber: what I'm trying to do is:
* bbrowning (~bbrowning at redhat/jboss/bbrowning) has joined #jboss-as7
* ChanServ gives voice to bbrowning
<maeste> emuckenhuber: https://github.com/maeste/jboss-as/commit/d08f758b39d6a83257745cf86fe9f7ced481c4cb#L1R78
<jbossbot> git [jboss-as] d08f758.. Stefano Maestri stats prototype
<maeste> emuckenhuber: but I'm getting this exception
<maeste> emuckenhuber: https://gist.github.com/1111413
<maeste> emuckenhuber: have you an idea what I'm doing wrong?
<emuckenhuber> maeste: yes
<maeste> emuckenhuber: sorry to ask you for a Brian's issue, but AFAIK Brian is away until 11 August
<maeste> emuckenhuber: cool
<emuckenhuber> maeste: basically you would need to register the handlers inside that operation
<maeste> emuckenhuber: yup, moreover after a service activated by this operation has been started
<maeste> emuckenhuber: it's the reason because I've added a listener
<maeste> emuckenhuber: line 91
<emuckenhuber> maeste: no, i'm saying operations have to be registered as part of operation handler itself
<emuckenhuber> which is basically the exception
<maeste> emuckenhuber: you have lost me
<emuckenhuber> actually all operation handlers should be registered as part of the Extension
<maeste> emuckenhuber: oki, but it's what AS7-772 try to solve
<jbossbot> jira [AS7-772] Allow operation handlers to register child ModelNodeRegistrations [Resolved (Done) Feature Request, Critical, Brian Stansberry] https://issues.jboss.org/browse/AS7-772
<maeste> emuckenhuber: at least AFAI understood
<maeste> emuckenhuber: this is our original problem
<emuckenhuber> hmm, imho that does not make any sense
<maeste> emuckenhuber: we have to register operation (metics in this case) after a datasource have been created
<emuckenhuber> well perhaps a bit
<emuckenhuber> anyway - you would have to register that as part of populateModel()
* asoldano is now known as asoldano_lunch
<maeste> emuckenhuber: because metrics are dynamic for us and need a concrete instance of ResourceAdapter/DS
<emuckenhuber> yeah, but it basically does not really comply with how the management model works
<maeste> emuckenhuber: there was a discussion on ML in May about that, and then Brian created 772
<emuckenhuber> you remember the subject?
<maeste> emuckenhuber: discussion subject was "access to the ModelNodeRegistration during handling of an operation and during deployment"
* kevinpollet (~kevinpoll at 217.112.54.72) has joined #jboss-as7
* abstractj (~abstractj at 186.202.49.66) has joined #jboss-as7
* hbraun (~hbraun at ppp-93-104-112-69.dynamic.mnet-online.de) has joined #jboss-as7
* hbraun has quit (Client Quit)
* miclorb_ has quit (Remote host closed the connection)
<emuckenhuber> maeste: hmm, ok that's an issue then
<maeste> emuckenhuber: so, basically you are saying it's not implented
<maeste> emuckenhuber: oki, I'll put down in my todo list
<maeste> emuckenhuber: better to wait for Brian, since I've discussed about that a lot with him
<emuckenhuber> maeste: well i would not say 'not implemented' - we actually have a check to prevent exactly this
<maeste> emuckenhuber: oki much stronger
<maeste> emuckenhuber:
<emuckenhuber> maeste: well perhaps you want to do a single operation handler which gives you all the metrics for now?
<emuckenhuber> not sure how critical that is for the console work
<maeste> emuckenhuber: not possible, it was already done, but it doesn't work
<emuckenhuber> why?
<maeste> emuckenhuber: or better it works, but not as expected
<maeste> emuckenhuber: because sometimes some metrics are not available
<maeste> emuckenhuber: to be more precise...
<maeste> emuckenhuber: it's done and it's already part of the current master
<emuckenhuber> maeste: PoolMetrics?
<maeste> emuckenhuber: but we would like to support a more complete metrics stuffs, and moreover to don't depend on IJ impls, but just spi
<maeste> emuckenhuber: yup
<maeste> emuckenhuber: I've just put this new dynamic implementation in my todo stack, waiting for 772. And today I had time to get into, but it's now clear that I haven't understood what 772 really is
<maeste> emuckenhuber: anyway no rush for that, I can wait Brian...moreover I'll be on PTO too next 2 weeks...I just have 1.5 day of work and my plate is full of other things to cook
<emuckenhuber> maeste: ok
<maeste> emuckenhuber: thanks for your time 

> access to the ModelNodeRegistration during handling of an operation and during deployment
> -----------------------------------------------------------------------------------------
>
>                 Key: AS7-1994
>                 URL: https://issues.jboss.org/browse/AS7-1994
>             Project: Application Server 7
>          Issue Type: Task
>    Affects Versions: 7.1.0.Alpha1
>            Reporter: Stefano Maestri
>            Assignee: Brian Stansberry
>             Fix For: 7.1.0.CR1
>
>
> Hi All,
> I'm trying to resume here the discussion I had yesterday on IRC with 
> Brian and Jesper.
> Basically JCA needs to have and already deployed instance of 
> ResourceAdapter when adding its metrics and some operation. The reason 
> for that is because some operation and metrics availability are known 
> only at runtime, depending from RA status and/or vendor specific feature 
> known only.
> Speaking from a Model point of view the basically issue is to have 
> access to the ModelNodeRegistration when the RA instance is created and 
> these runtime infos are available. There are 2 cases:
> 1) during handling ADD operation for a DataSource or special 
> ResourceAdapter creation withour rar deployment (like hornetQ).
> 2) during foo.rar deployment chain
> We have also discussed where we can put these operation in the model 
> tree. Also in this case there are two possible places:
> 1) at subsystem level for special no-deployment RA (DataSources and 
> HornetQ atm). So we will obtain something like  
> /subsystem=datasource/data-source=myDS and /subsystem=hq/ra
> 2) at DUP level /deployment=foo.rar Having this deployment support we 
> can remove the current operation in /subsystem=resource-adapters that is 
> redudant, referring the same RA (or better a subset of deployed ones)
> Hoping to have written all the matters discussed, feel free to integrate 
> and/or ask.
> regards
> S.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira