[jboss-jira] [JBoss JIRA] (AS7-1983) Logger handler level should be required

[Tristan Tarrant (Updated) (JIRA)]

     [ https://issues.jboss.org/browse/AS7-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tristan Tarrant updated AS7-1983:
---------------------------------

    Description: 
I believe there is a copy/paste mistake in LoggingSubsystemProviders.java in the following code:

{code:title=LoggingSubsystemProviders.java}
private static void addCommonLoggerRequestProperties(final ModelNode modelNode, final ResourceBundle bundle) {
        modelNode.get(REQUEST_PROPERTIES, LEVEL, TYPE).set(ModelType.STRING);
        modelNode.get(REQUEST_PROPERTIES, LEVEL, DESCRIPTION).set(bundle.getString("handler.level"));
        modelNode.get(REQUEST_PROPERTIES, LEVEL, REQUIRED).set(true);

        modelNode.get(REQUEST_PROPERTIES, FILTER, TYPE).set(ModelType.STRING);
        modelNode.get(REQUEST_PROPERTIES, FILTER, DESCRIPTION).set(bundle.getString("handler.filter"));
        modelNode.get(REQUEST_PROPERTIES, LEVEL, REQUIRED).set(false);

        modelNode.get(REQUEST_PROPERTIES, HANDLERS, TYPE).set(ModelType.LIST);
        modelNode.get(REQUEST_PROPERTIES, HANDLERS, VALUE_TYPE).set(ModelType.STRING);
        modelNode.get(REQUEST_PROPERTIES, HANDLERS, DESCRIPTION).set(bundle.getString("logger.handlers"));
        modelNode.get(REQUEST_PROPERTIES, HANDLERS, REQUIRED).set(false);
    }
{code}

the LEVEL property's REQUIRED flag is reset to false, instead of setting the FILTER's flag. Thus:

{code:title=LoggingSubsystemProviders.java}
private static void addCommonLoggerRequestProperties(final ModelNode modelNode, final ResourceBundle bundle) {
        modelNode.get(REQUEST_PROPERTIES, LEVEL, TYPE).set(ModelType.STRING);
        modelNode.get(REQUEST_PROPERTIES, LEVEL, DESCRIPTION).set(bundle.getString("handler.level"));
        modelNode.get(REQUEST_PROPERTIES, LEVEL, REQUIRED).set(true);

        modelNode.get(REQUEST_PROPERTIES, FILTER, TYPE).set(ModelType.STRING);
        modelNode.get(REQUEST_PROPERTIES, FILTER, DESCRIPTION).set(bundle.getString("handler.filter"));
        modelNode.get(REQUEST_PROPERTIES, FILTER, REQUIRED).set(false);

        modelNode.get(REQUEST_PROPERTIES, HANDLERS, TYPE).set(ModelType.LIST);
        modelNode.get(REQUEST_PROPERTIES, HANDLERS, VALUE_TYPE).set(ModelType.STRING);
        modelNode.get(REQUEST_PROPERTIES, HANDLERS, DESCRIPTION).set(bundle.getString("logger.handlers"));
        modelNode.get(REQUEST_PROPERTIES, HANDLERS, REQUIRED).set(false);
    }
{code}

  was:
I believe there is a copy/paste mistake in LoggingSubsystemProviders.java in the following code:

private static void addCommonLoggerRequestProperties(final ModelNode modelNode, final ResourceBundle bundle) {
        modelNode.get(REQUEST_PROPERTIES, LEVEL, TYPE).set(ModelType.STRING);
        modelNode.get(REQUEST_PROPERTIES, LEVEL, DESCRIPTION).set(bundle.getString("handler.level"));
        modelNode.get(REQUEST_PROPERTIES, LEVEL, REQUIRED).set(true);

        modelNode.get(REQUEST_PROPERTIES, FILTER, TYPE).set(ModelType.STRING);
        modelNode.get(REQUEST_PROPERTIES, FILTER, DESCRIPTION).set(bundle.getString("handler.filter"));
        modelNode.get(REQUEST_PROPERTIES, LEVEL, REQUIRED).set(false);

        modelNode.get(REQUEST_PROPERTIES, HANDLERS, TYPE).set(ModelType.LIST);
        modelNode.get(REQUEST_PROPERTIES, HANDLERS, VALUE_TYPE).set(ModelType.STRING);
        modelNode.get(REQUEST_PROPERTIES, HANDLERS, DESCRIPTION).set(bundle.getString("logger.handlers"));
        modelNode.get(REQUEST_PROPERTIES, HANDLERS, REQUIRED).set(false);
    }

the LEVEL property's REQUIRED flag is reset to false, instead of setting the FILTER's flag.


    
> Logger handler level should be required
> ---------------------------------------
>
>                 Key: AS7-1983
>                 URL: https://issues.jboss.org/browse/AS7-1983
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Logging
>    Affects Versions: 7.1.0.Alpha1
>            Reporter: Tristan Tarrant
>            Assignee: James Perkins
>            Priority: Minor
>
> I believe there is a copy/paste mistake in LoggingSubsystemProviders.java in the following code:
> {code:title=LoggingSubsystemProviders.java}
> private static void addCommonLoggerRequestProperties(final ModelNode modelNode, final ResourceBundle bundle) {
>         modelNode.get(REQUEST_PROPERTIES, LEVEL, TYPE).set(ModelType.STRING);
>         modelNode.get(REQUEST_PROPERTIES, LEVEL, DESCRIPTION).set(bundle.getString("handler.level"));
>         modelNode.get(REQUEST_PROPERTIES, LEVEL, REQUIRED).set(true);
>         modelNode.get(REQUEST_PROPERTIES, FILTER, TYPE).set(ModelType.STRING);
>         modelNode.get(REQUEST_PROPERTIES, FILTER, DESCRIPTION).set(bundle.getString("handler.filter"));
>         modelNode.get(REQUEST_PROPERTIES, LEVEL, REQUIRED).set(false);
>         modelNode.get(REQUEST_PROPERTIES, HANDLERS, TYPE).set(ModelType.LIST);
>         modelNode.get(REQUEST_PROPERTIES, HANDLERS, VALUE_TYPE).set(ModelType.STRING);
>         modelNode.get(REQUEST_PROPERTIES, HANDLERS, DESCRIPTION).set(bundle.getString("logger.handlers"));
>         modelNode.get(REQUEST_PROPERTIES, HANDLERS, REQUIRED).set(false);
>     }
> {code}
> the LEVEL property's REQUIRED flag is reset to false, instead of setting the FILTER's flag. Thus:
> {code:title=LoggingSubsystemProviders.java}
> private static void addCommonLoggerRequestProperties(final ModelNode modelNode, final ResourceBundle bundle) {
>         modelNode.get(REQUEST_PROPERTIES, LEVEL, TYPE).set(ModelType.STRING);
>         modelNode.get(REQUEST_PROPERTIES, LEVEL, DESCRIPTION).set(bundle.getString("handler.level"));
>         modelNode.get(REQUEST_PROPERTIES, LEVEL, REQUIRED).set(true);
>         modelNode.get(REQUEST_PROPERTIES, FILTER, TYPE).set(ModelType.STRING);
>         modelNode.get(REQUEST_PROPERTIES, FILTER, DESCRIPTION).set(bundle.getString("handler.filter"));
>         modelNode.get(REQUEST_PROPERTIES, FILTER, REQUIRED).set(false);
>         modelNode.get(REQUEST_PROPERTIES, HANDLERS, TYPE).set(ModelType.LIST);
>         modelNode.get(REQUEST_PROPERTIES, HANDLERS, VALUE_TYPE).set(ModelType.STRING);
>         modelNode.get(REQUEST_PROPERTIES, HANDLERS, DESCRIPTION).set(bundle.getString("logger.handlers"));
>         modelNode.get(REQUEST_PROPERTIES, HANDLERS, REQUIRED).set(false);
>     }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira