[jboss-jira] [JBoss JIRA] (AS7-2102) TS: Add module for shared util classes
Ondrej Zizka (Issue Comment Edited) (JIRA)
jira-events at lists.jboss.org
Thu Oct 13 20:19:16 EDT 2011
[ https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634732#comment-12634732 ]
Ondrej Zizka edited comment on AS7-2102 at 10/13/11 8:18 PM:
-------------------------------------------------------------
(02:11:23) ozizka: FYI, there's going to be some space for shared util classes, do you have some candidates to put there?
(02:12:14) barreiro: well ... there are a few classes that come from security that I believe that can be shared
(02:13:14) barreiro: there were also a couple of tests that used some mock EJBs, but these ones were skipped ... but I may need those classes further down the road.
(02:15:20) barreiro: sometimes I ask myself if it's better to have these classes shared or everyone has their own copy (once by module) ...
(02:15:56) barreiro: or else you never know where those classes are being used.
(02:17:47) ozizka: +1, but, with proper comments and someone watching/coordinating, perhaps shared could be a benefit
(02:21:47) barreiro: IMHO having a coordinator is a step forward. AS6 testsuite, although not being too bad, is't too good either.
(02:23:27) ozizka: Such coordinator(s) would likely be author of original util class impl - that one best knows what was the purpose and suggest/perform the right refactoring
was (Author: ozizka):
(02:11:23) ozizka: FYI, there's going to be some space for shared util classes, do you have some candidates to put there?
(02:12:14) barreiro: well ... there are a few classes that come from security that I believe that can be shared
(02:13:14) barreiro: there were also a couple of tests that used some mock EJBs, but these ones were skipped ... but I may need those classes further down the road.
(02:15:20) barreiro: sometimes I ask myself if it's better to have these classes shared or everyone has their own copy (once by module) ...
(02:15:56) barreiro: or else you never know where those classes are being used.
(02:17:47) ozizka: +1, but, with proper comments and someone watching/coordinating, perhaps shared could be a benefit
> TS: Add module for shared util classes
> --------------------------------------
>
> Key: AS7-2102
> URL: https://issues.jboss.org/browse/AS7-2102
> Project: Application Server 7
> Issue Type: Sub-task
> Components: Test Suite
> Reporter: Ondrej Zizka
> Assignee: Ondrej Zizka
>
> To prevent people coding their own impl of what was coded twenty-times in other packages of TS.
> Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jboss-jira
mailing list