[jboss-jira] [JBoss JIRA] (AS7-1795) Fix the ModCluster description providers for the improved validation in jboss-as-subsystem-test

Jean-Frederic Clere (Resolved) (JIRA) jira-events at lists.jboss.org
Fri Oct 21 11:33:45 EDT 2011


     [ https://issues.jboss.org/browse/AS7-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Frederic Clere resolved AS7-1795.
--------------------------------------

    Resolution: Done


Fix by https://github.com/jbossas/jboss-as/pull/484
                
> Fix the ModCluster description providers for the improved validation in jboss-as-subsystem-test
> -----------------------------------------------------------------------------------------------
>
>                 Key: AS7-1795
>                 URL: https://issues.jboss.org/browse/AS7-1795
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: Clustering
>            Reporter: Kabir Khan
>            Assignee: Jean-Frederic Clere
>             Fix For: 7.1.0.Beta1
>
>
> I added a test called ModClusterSubsystemTestCase, which uses our subsystem testing framework which attempts to validate the description providers, this will be committed to upstream in the next few days. 
> To make the tests pass I had to override AdditionalInitialization.getModelValidationConfiguration() and isValidateOperations() as follows:
> {code}
>         @Override
>         protected ValidationConfiguration getModelValidationConfiguration() {
>             return null;
>         }
>          @Override
>          protected boolean isValidateOperations() {
>              //TODO fix providers https://issues.jboss.org/browse/AS7-1789
>              return false;
>          }
> {code}
> Returning null basically turns off validation of the providers, and the isValidateOperations() override turns off validation of the contents of the actual operations. What I have added is a minimum of what is required for subsystem testing, the test framework allows you to do a lot of other stuff, see the jmx subsystem test for some examples.
> The wip lives at https://github.com/kabir/jboss-as/tree/subsystem-test-model-fixes
> The above is standard text as I'm going through and creating tests. The test has been @Ignored due to a further failure once validation 'passes' (i.e. the validation is not run due to the flags set)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jboss-jira mailing list