[jboss-jira] [JBoss JIRA] Updated: (AS7-1787) Fix JGroups description providers for the improved validation in jboss-as-subsystem-test

[Kabir Khan (JIRA)]

     [ https://issues.jboss.org/browse/AS7-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kabir Khan updated AS7-1787:
----------------------------

       Assignee: Paul Ferraro  (was: Thomas Diesler)
    Description: 
I added a test called JGroupsSubsystemTest which uses our subsystem testing framework which attempts to validate the description providers, this will be committed to upstream in the next few days. 
To make the tests pass I had to override AdditionalInitialization.getModelValidationConfiguration() as follows:

{code}
            @Override
            protected ValidationConfiguration getModelValidationConfiguration() {
                return null;
            }
{code}
Returning null basically turns off validation of the providers. What I have added is a minimum of what is required for subsystem testing, the test framework allows you to do a lot of other stuff, see the jmx subsystem test for some examples.

The wip lives at https://github.com/kabir/jboss-as/tree/subsystem-test-model-fixes

  was:
I am adding some more validation of the model. This will be committed to upstream in the next few days. To make the security tests pass I had to override AdditionalInitialization.getModelValidationConfiguration() as follows:

{code}
            @Override
            protected ValidationConfiguration getModelValidationConfiguration() {
                return null;
            }
{code}
Returning null basically turns off validation of the providers. These are the errors that happen (this might change a bit before I commit the final version of the validation stuff):
{code}
VALIDATION ERRORS IN MODEL:
Invalid key 'attributes' found for child type 'configuration' @[("subsystem" => "osgi")]
No value-type for type=OBJECT {"description" => "The configuration data associated with the PID.","type" => OBJECT,"required" => true,"acces
s-type" => "read-only","storage" => "configuration"} for attribute 'entries'[
    ("subsystem" => "osgi"),
    ("configuration" => "*")
]
No value-type for type=OBJECT {"description" => "The configuration data associated with the PID.","type" => OBJECT,"required" => true} for o
peration parameter 'add.entries' @[
    ("subsystem" => "osgi"),
    ("configuration" => "*")
]
Invalid key 'attributes' found for child type 'property' @[("subsystem" => "osgi")]
Invalid key 'attributes' found for child type 'module' @[("subsystem" => "osgi")]
{code}

The work in progress lives at https://github.com/kabir/jboss-as/tree/subsystem-test-model-fixes


    Component/s: Clustering
                     (was: OSGi)


> Fix JGroups description providers for the improved validation in jboss-as-subsystem-test
> ----------------------------------------------------------------------------------------
>
>                 Key: AS7-1787
>                 URL: https://issues.jboss.org/browse/AS7-1787
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: Clustering
>            Reporter: Kabir Khan
>            Assignee: Paul Ferraro
>             Fix For: 7.1.0.Alpha1
>
>
> I added a test called JGroupsSubsystemTest which uses our subsystem testing framework which attempts to validate the description providers, this will be committed to upstream in the next few days. 
> To make the tests pass I had to override AdditionalInitialization.getModelValidationConfiguration() as follows:
> {code}
>             @Override
>             protected ValidationConfiguration getModelValidationConfiguration() {
>                 return null;
>             }
> {code}
> Returning null basically turns off validation of the providers. What I have added is a minimum of what is required for subsystem testing, the test framework allows you to do a lot of other stuff, see the jmx subsystem test for some examples.
> The wip lives at https://github.com/kabir/jboss-as/tree/subsystem-test-model-fixes

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira