[jboss-jira] [JBoss JIRA] Updated: (AS7-1792) Fix the Logging description providers for the improved validation in jboss-as-subsystem-test

[Kabir Khan (JIRA)]

     [ https://issues.jboss.org/browse/AS7-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kabir Khan updated AS7-1792:
----------------------------

    Description: 
I added a test called LoggingSubsystemTestCase, which uses our subsystem testing framework which attempts to validate the description providers, this will be committed to upstream in the next few days. 
To make the tests pass I had to override AdditionalInitialization.getModelValidationConfiguration() and isValidateOperations() as follows:

{code}
         @Override
         protected ValidationConfiguration getModelValidationConfiguration() {
             return null;
         }


          @Override
          protected boolean isValidateOperations() {
              //TODO fix providers https://issues.jboss.org/browse/AS7-1789
              return false;
          }

{code}
Returning null basically turns off validation of the providers, and the isValidateOperations() override turns off validation of the contents of the actual operations. What I have added is a minimum of what is required for subsystem testing, the test framework allows you to do a lot of other stuff, see the jmx subsystem test for some examples.

The wip lives at https://github.com/kabir/jboss-as/tree/subsystem-test-model-fixes

The above is standard text as I'm going through and creating tests. The test has been @Ignored due to a further failure once validation 'passes' (i.e. the validation is not run due to the flags set)

  was:
I added a test called LoggingSubsystemTestCase, which uses our subsystem testing framework which attempts to validate the description providers, this will be committed to upstream in the next few days. 
To make the tests pass I had to override AdditionalInitialization.getModelValidationConfiguration() and isValidateOperations() as follows:

{code}
         @Override
         protected ValidationConfiguration getModelValidationConfiguration() {
             return null;
         }


          @Override
          protected boolean isValidateOperations() {
              //TODO fix providers https://issues.jboss.org/browse/AS7-1789
              return false;
          }

{code}
Returning null basically turns off validation of the providers, and the isValidateOperations() override turns off validation of the contents of the actual operations. What I have added is a minimum of what is required for subsystem testing, the test framework allows you to do a lot of other stuff, see the jmx subsystem test for some examples.

The wip lives at https://github.com/kabir/jboss-as/tree/subsystem-test-model-fixes

The above is standard text as I'm going through and creating tests. The test has been @Ignored due to a further failure once validation passes



> Fix the Logging description providers for the improved validation in jboss-as-subsystem-test
> --------------------------------------------------------------------------------------------
>
>                 Key: AS7-1792
>                 URL: https://issues.jboss.org/browse/AS7-1792
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: Logging
>    Affects Versions: 7.1.0.Alpha1
>            Reporter: Kabir Khan
>            Assignee: James Perkins
>
> I added a test called LoggingSubsystemTestCase, which uses our subsystem testing framework which attempts to validate the description providers, this will be committed to upstream in the next few days. 
> To make the tests pass I had to override AdditionalInitialization.getModelValidationConfiguration() and isValidateOperations() as follows:
> {code}
>          @Override
>          protected ValidationConfiguration getModelValidationConfiguration() {
>              return null;
>          }
>           @Override
>           protected boolean isValidateOperations() {
>               //TODO fix providers https://issues.jboss.org/browse/AS7-1789
>               return false;
>           }
> {code}
> Returning null basically turns off validation of the providers, and the isValidateOperations() override turns off validation of the contents of the actual operations. What I have added is a minimum of what is required for subsystem testing, the test framework allows you to do a lot of other stuff, see the jmx subsystem test for some examples.
> The wip lives at https://github.com/kabir/jboss-as/tree/subsystem-test-model-fixes
> The above is standard text as I'm going through and creating tests. The test has been @Ignored due to a further failure once validation 'passes' (i.e. the validation is not run due to the flags set)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira