[jboss-jira] [JBoss JIRA] (JGRP-1443) Null pointer exception testing proposed fix for JGRP-1426

[David Hotham (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681519#comment-12681519 ] 

David Hotham commented on JGRP-1443:
------------------------------------

I confirm that I'm no longer hitting the NPE.

To try and figure out whether the tight loop issue is all part of the same thing or not, I added some trace to your fix so that I would be able to see when we went through it.  And sure enough, just before getting stuck, we ran through the new code.

So I'm pretty convinced that we should tracking this all under the same JIRA; it does indeed look as though it's something about the new fix that triggers the tight loop.

If there's anything I can do to help eg test fixes or gather trace, please just ask.

David
                
> Null pointer exception testing proposed fix for JGRP-1426
> ---------------------------------------------------------
>
>                 Key: JGRP-1443
>                 URL: https://issues.jboss.org/browse/JGRP-1443
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 3.0.8
>            Reporter: David Hotham
>            Assignee: Bela Ban
>             Fix For: 3.0.9, 3.1
>
>         Attachments: jgroups-3.0.9.Final.jar
>
>
> Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
> SEVERE: failed sending message to 10.239.0.5 (185 bytes):
> java.lang.NullPointerException, cause: null
> java.lang.NullPointerException
>         at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
>         at org.jgroups.util.Util.writeStreamable(Util.java:934)
>         at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
>         at org.jgroups.Message.writeHeader(Message.java:891)
>         at org.jgroups.Message.writeTo(Message.java:698)
>         at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
>         at org.jgroups.protocols.TP.send(TP.java:1279)
>         at org.jgroups.protocols.TP.down(TP.java:1138)
>         at org.jgroups.protocols.Discovery.down(Discovery.java:573)
>         at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
>         at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
>         at org.jgroups.protocols.FD.down(FD.java:308)
>         at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
>         at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
>         at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
>         at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
>         at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
>         at org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
>         at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
>         at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
>         at java.lang.Thread.run(Thread.java:662)
> You said: 
> {quote}
> ah, ok, this is a change I made recently, to reduce the size of digests.
> Can you open a JIRA so we can track this ?
> I'll fix it this week.
> {quote}
> ... so here we are.
> Thanks!
> David

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira