[jboss-jira] [JBoss JIRA] (AS7-4394) ConnectionFactory factory-type is broken

[Jeff Mesnil (JIRA)]

     [ https://issues.jboss.org/browse/AS7-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Mesnil reassigned AS7-4394:
--------------------------------

    Assignee: Jeff Mesnil  (was: Andy Taylor)

    
> ConnectionFactory factory-type is broken
> ----------------------------------------
>
>                 Key: AS7-4394
>                 URL: https://issues.jboss.org/browse/AS7-4394
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: JMS
>    Affects Versions: 7.1.1.Final
>            Reporter: Jeff Mesnil
>            Assignee: Jeff Mesnil
>
> User reported that he could not set the <factory-type> when creating a connection factory:
> {noformat}
> <connection-factory name="RemoteConnectionFactory">
>   <factory-type>XA_GENERIC</factory-type>
>   <connectors>
>     <connector-ref connector-name="netty"/>
>   </connectors>
>   <entries>
>     <entry name="RemoteConnectionFactory"/>
>     <entry name="java:jboss/exported/jms/RemoteConnectionFactory"/>
>   </entries>
>   <ha>true</ha>
> </connection-factory>
> {noformat}
> I am not sure to understand what is supposed to do this factory-type attribute...
> It is not correctly described in the connection-factory description in the CLI:
> {noformat}
> [standalone at localhost:9999 /] /subsystem=messaging/hornetq-server=default/connection-factory=RemoteConnectionFactory/:read-resource-description
> ...
> "factory-type" => {
>                 "description" => "The type of connection factory. 0 = jms cf, 1 = queue cf, 2 = topic cf, 3 = xa cf, 4 = xa queue cf, 5 = xa topic cf",
>                 "type" => INT,
>                 "nillable" => false,
>                 "allowed" => [
>                     undefined,
>                     undefined,
>                     undefined,
>                     undefined,
>                     undefined,
>                     undefined
>                 ],
>                 "access-type" => "read-only",
>                 "storage" => "runtime"
>             },
> ...
> {noformat}
> The allowed values are not properly defined (code in MessagingDescriptions.getConnectionFactory(Locale) is bogus, I'll fix it...)
> I don't understand why it is defined as read only but in ConnectionFactoryAdd we try to set the factoryType based on the resolved CONNECTION_FACTORY_TYPE attribute. This attribute is not defined among the connection factory attributes and can not be set when creating a cf with the CLI.
> I don't understand why the "factory-type" model node is defined twice (in CommonAttributes and in MessagingDescriptions.getConnectionFactory(Locale)). To me, these 2 attributes are the same.
> I'll fix it with the expectation that it is valid for an user to set the type of connection factory (with or w/o XA, queue/topic/generic) when he adds one through configuration or the CLI. Does that sound correct?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira