[jboss-jira] [JBoss JIRA] (LOGTOOL-44) Make configurable whether @Override annotation shall be added

Thu Apr 12 09:27:47 EDT 2012

    [ https://issues.jboss.org/browse/LOGTOOL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683500#comment-12683500 ] 

Hardy Ferentschik commented on LOGTOOL-44:
------------------------------------------

> Since the JBoss Logging library is compiled to Java 6 I'm not sure this would work anyway. 

Right, there is a problem. See https://hibernate.onjira.com/browse/HV-569
So even though Hibernate Validator itself would still run in a Java 5 environment, by switching to JBoss logging we basically force users to use Java 6. Couldn't you just compile JBoss Logging with target 1.5? 

> Make configurable whether @Override annotation shall be added
> -------------------------------------------------------------
>
>                 Key: LOGTOOL-44
>                 URL: https://issues.jboss.org/browse/LOGTOOL-44
>             Project: Log Tool
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 1.0.1.Final
>            Reporter: Gunnar Morling
>            Assignee: James Perkins
>
> The annotation processor adds the {{@java.lang.Override}} annotation to the methods of generated log or message bundle classes. For methods implementing interface methods this is allowed only in Java 6 and above, while in Java 5 {{@Override}} is only allowed for methods overriding methods from superclasses.
> Therefore compilation of the generated classes fails using Java 5. To address this issue, the annotation should be added conditionally based on the current source level.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira