[jboss-jira] [JBoss JIRA] (LOGTOOL-44) Make configurable whether @Override annotation shall be added

[Hardy Ferentschik (JIRA)]

    [ https://issues.jboss.org/browse/LOGTOOL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12684372#comment-12684372 ] 

Hardy Ferentschik commented on LOGTOOL-44:
------------------------------------------

{quote}
Let me make it perfectly clear that 1.5 compatibility is a non-requirement at the moment.
{quote}

If you are not using any Java 6 specific features it is just a question of adding 'target = 1.5' to your compiler flags. If it is just about _Arrays#copyOfRange_, just add method to the code base. I think the advantage is outweighing the fact that you have "duplicated" code. Even though Java 5 is out of date, I think there are still a lot of deployments out there which run on this JVM. I just see it as an advantage if they have the chance to upgrade parts of their system (as they could w/ Validator if not for the logging framework)

{quote}
If you want jboss-logging to actually execute on 1.5, you're going to have to use a retroweaver of some sort to do it.
{quote}

How would that look like? I am not sure this is possible.
                
> Make configurable whether @Override annotation shall be added
> -------------------------------------------------------------
>
>                 Key: LOGTOOL-44
>                 URL: https://issues.jboss.org/browse/LOGTOOL-44
>             Project: Log Tool
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 1.0.1.Final
>            Reporter: Gunnar Morling
>            Assignee: James Perkins
>
> The annotation processor adds the {{@java.lang.Override}} annotation to the methods of generated log or message bundle classes. For methods implementing interface methods this is allowed only in Java 6 and above, while in Java 5 {{@Override}} is only allowed for methods overriding methods from superclasses.
> Therefore compilation of the generated classes fails using Java 5. To address this issue, the annotation should be added conditionally based on the current source level.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira