[jboss-jira] [JBoss JIRA] (LOGTOOL-45) Avoid unnecessary calls to String#format()
Hardy Ferentschik (JIRA)
jira-events at lists.jboss.org
Mon Apr 23 08:00:18 EDT 2012
[ https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12686593#comment-12686593 ]
Hardy Ferentschik commented on LOGTOOL-45:
------------------------------------------
+1 for an option. The overhead for _String#format_ seem considerable. An alternative would be to cache the strings for method calls w/o parameters. This could eg be done once of at class initialization.
> Avoid unnecessary calls to String#format()
> ------------------------------------------
>
> Key: LOGTOOL-45
> URL: https://issues.jboss.org/browse/LOGTOOL-45
> Project: Log Tool
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Reporter: Gunnar Morling
> Assignee: James Perkins
>
> Generated message bundle methods always contain an invocation of {{String#format()}} also if there actually is no parameter to be replaced, e.g. like this:
> {code}
> @Override
> public final String mustNotBeNull() {
> String result = String.format(mustNotBeNull0$str());
> return result;
> }
> {code}
> AFAICS the invocation of {{format()}} seems superfluous, instead the String might directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jboss-jira
mailing list