[jboss-jira] [JBoss JIRA] (LOGTOOL-46) jboss-logging-generator singletons don't play nice with Eclipse APT

[James Perkins (JIRA)]

     [ https://issues.jboss.org/browse/LOGTOOL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Perkins resolved LOGTOOL-46.
----------------------------------

    Fix Version/s: 1.0.2.Final
       Resolution: Done


Merged https://github.com/jboss-logging/jboss-logging-tools/commit/3f3d2b060829902b066802b929d453a3afcf2f6d
                
>  jboss-logging-generator singletons don't play nice with Eclipse APT
> --------------------------------------------------------------------
>
>                 Key: LOGTOOL-46
>                 URL: https://issues.jboss.org/browse/LOGTOOL-46
>             Project: Log Tool
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 1.0.0.CR5
>         Environment: Eclipse 3.7
>            Reporter: Fred Bricon
>            Assignee: James Perkins
>             Fix For: 1.0.2.Final
>
>         Attachments: jbosslogging-ap-errors.png, test-logging.zip
>
>
> While testing [m2e-apt|https://github.com/jbosstools/m2e-apt] on [hibernate-search|https://github.com/hibernate/hibernate-search], I got these strange errors :
> !jbosslogging-ap-errors.png!
> All the log methods are marked as being duplicate. My gut feeling is this is due to [MessageIdValidator being a singleton|https://github.com/jboss-logging/jboss-logging-tools/blob/4b437dd4c7626f4c5da9fb99923fd2cac4e87a78/src/main/java/org/jboss/logging/processor/validation/MessageIdValidator.java#L44] : all AP work in eclipse reuses the same instance between each incremental builds. So validating the same file more than once lead to these errors.
> The generator being a build tool, it doesn't make much sense to use singletons at all, performance-wise.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira