[jboss-jira] [JBoss JIRA] (AS7-355) Store config file comments in the model

Wed Aug 1 16:59:07 EDT 2012

    [ https://issues.jboss.org/browse/AS7-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709281#comment-12709281 ] 

Guillaume Grossetie edited comment on AS7-355 at 8/1/12 4:59 PM:
-----------------------------------------------------------------

Hi Brian,

Thanks for taking some time on your holidays to answer :)

My biggest concern is to know where the comment must be stored. As far as I understand ModelNode represents, in this particular context, elements of an xml file. The AbstractConfigurationPersister marshall as xml from a ModelNode but where and how the xml is parsed into ModelNode ?

ModelNode (jboss-dmr) is quite low level and adding an additional variable to store the comment is maybe a bad idea ? But can a StringModelValue represent a comment ?

I also have a question about STXM-6, Do we need to support comment on comment like :
{code:xml} 
<!-- Comment 1 -->
<!-- Comment 2 -->
<root name="root"/>
{code} 

Must #getTagComment() on root return "Comment 2" ? Do we need to support #getTagComment() on  ?

Thanks,
Guillaume

      was (Author: grossetieg):
    Hi Brian,

Thanks for taking some time on your holidays to answer :)

My biggest concern is to know where the comment must be stored. As far as I understand ModelNode represents, in this particular context, elements of an xml file. The AbstractConfigurationPersister marshall as xml from a ModelNode but where and how the xml is parsed into ModelNode ?

ModelNode (jboss-dmr) is quite low level and adding an additional variable to store the comment is maybe a bad idea ? But can a StringModelValue represent a comment ?

I also have a question about STXM-6, Do we need to support comment on comment like :
{{<!-- Comment 1 -->
<!-- Comment 2 -->
<root name="root"/>}}

Must #getTagComment() on root return "Comment 2" ? Do we need to support #getTagComment() on  ?

Thanks,
Guillaume

> Store config file comments in the model
> ---------------------------------------
>
>                 Key: AS7-355
>                 URL: https://issues.jboss.org/browse/AS7-355
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: Domain Management
>            Reporter: Brian Stansberry
>             Fix For: Open To Community
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira