[jboss-jira] [JBoss JIRA] (JBLOGGING-85) slf4j-jboss-logmanager does not support parametization of a logging statement in the presence of a Throwable

Hercules Zeus (JIRA) jira-events at lists.jboss.org
Thu Aug 9 05:07:07 EDT 2012


Hercules Zeus created JBLOGGING-85:
--------------------------------------

             Summary: slf4j-jboss-logmanager does not support parametization of a logging statement in the presence of a Throwable
                 Key: JBLOGGING-85
                 URL: https://issues.jboss.org/browse/JBLOGGING-85
             Project: JBoss Logging
          Issue Type: Bug
      Security Level: Public (Everyone can see)
          Components: slf4j-jboss-logmanager
            Reporter: Hercules Zeus
            Assignee: David Lloyd


http://www.slf4j.org/faq.html#paramException describes that from slf4j 1.6 onwards doing the following will print a stacktrace:

logger.error("Failed to format {}", s, e);

However, due to the implementation of org.slf4j.impl.MessageFormatter in slf4j-jboss-logmanager, when logger.error(String, Object, Object) is called, even if the third parameter is a Throwable, it is not recognised as such.

Investigating further, it seems that org.slf4j.impl.MessageFormatter is probably just an old copy of org.slf4j.helpers.MessageFormatter in slfj-api 1.6.1, where most formatting methods used to return a String now returns a FormattingTuple.

This issue can be fixed by making all calls in Slf4Logger to org.slf4j.impl.MessageFormatter to call org.slf4j.helpers.MessageFormatter instead and appropriately call ExtLogRecord.setThrown(formattingTuple.getThrowable()).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jboss-jira mailing list