[jboss-jira] [JBoss JIRA] (JBCOMMON-129) BasicThreadPool has unsynchronized collection

Mon Aug 13 04:52:16 EDT 2012

     [ https://issues.jboss.org/browse/JBCOMMON-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bartosz Baranowski updated JBCOMMON-129:
----------------------------------------

    Attachment: JBCOMMON_129.patch

Slightly altered patch. I was kind of fooled by name of PriorityBlockingQueue ( it should be something like SynchronizedPriorityQueue, "Blocking" and JDOC suggests it block fetch till there is something inside)
Also simplified getNextTimeout

> BasicThreadPool has unsynchronized collection
> ---------------------------------------------
>
>                 Key: JBCOMMON-129
>                 URL: https://issues.jboss.org/browse/JBCOMMON-129
>             Project: JBoss Common
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.20.GA
>            Reporter: Bartosz Baranowski
>            Assignee: Bartosz Baranowski
>            Priority: Blocker
>             Fix For: 2.2.21.GA
>
>         Attachments: JBCOMMON_129.patch, JBCOMMON_129.patch
>
>
> BasicThreadPool has the PriorityQueue. This structure is accessed by various threads - to be precise add and remove operations are called concurrently. This may cause NPE on add operation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira