[jboss-jira] [JBoss JIRA] (AS7-5404) Review use of 'default' for nillable 'roles' attributes in core-address

[Kabir Khan (JIRA)]

Kabir Khan created AS7-5404:
-------------------------------

             Summary: Review use of 'default' for nillable 'roles' attributes in core-address
                 Key: AS7-5404
                 URL: https://issues.jboss.org/browse/AS7-5404
             Project: Application Server 7
          Issue Type: Feature Request
          Components: JMS
            Reporter: Kabir Khan
            Assignee: Jeff Mesnil
             Fix For: 7.2.0.Alpha1


CompareModelVersionsUtil reports the following before and after the upgrade messaging to use resource definition
{code}
====== Resource root address: ["subsystem" => "messaging"] - Current version: 1.2.0; legacy version: 1.2.0 =======
--- Problems for relative address to root ["hornetq-server" => "*","core-address" => "*"]:
Different 'value-type' for attribute 'roles'. Current: {
    "name" => {
        "type" => STRING,
        "description" => "The name of the security role.",
        "expressions-allowed" => false,
        "nillable" => false,
        "min-length" => 1L,
        "max-length" => 2147483647L
    },
    "send" => {
        "type" => BOOLEAN,
        "description" => "Whether the role has permission to send to the address.",
        "expressions-allowed" => false,
        "nillable" => false,
        "default" => false
    },
    "consume" => {
        "type" => BOOLEAN,
        "description" => "Whether the role has permission to consume from the address.",
        "expressions-allowed" => false,
        "nillable" => false,
        "default" => false
    },
    "create-durable-queue" => {
        "type" => BOOLEAN,
        "description" => "Whether the role has permission to create a durable queue.",
        "expressions-allowed" => false,
        "nillable" => false,
        "default" => false
    },
    "delete-durable-queue" => {
        "type" => BOOLEAN,
        "description" => "Whether the role has permission to delete a durable queue.",
        "expressions-allowed" => false,
        "nillable" => false,
        "default" => false
    },
    "create-non-durable-queue" => {
        "type" => BOOLEAN,
        "description" => "Whether the role has permission to create a non-durable queue.",
        "expressions-allowed" => false,
        "nillable" => false,
        "default" => false
    },
    "delete-non-durable-queue" => {
        "type" => BOOLEAN,
        "description" => "Whether the role has permission to delete a non-durable queue.",
        "expressions-allowed" => false,
        "nillable" => false,
        "default" => false
    },
    "manage" => {
        "type" => BOOLEAN,
        "description" => "Whether the role has permission to manage the address.",
        "expressions-allowed" => false,
        "nillable" => false,
        "default" => false
    }
}; legacy: {
    "name" => {
        "description" => "The name of a security role.",
        "type" => STRING,
        "nillable" => false
    },
    "send" => {
        "description" => "This permission allows the user to send a message to matching addresses.",
        "type" => BOOLEAN,
        "nillable" => false
    },
    "consume" => {
        "description" => "his permission allows the user to consume a message from a queue bound to matching addresses.",
        "type" => BOOLEAN,
        "nillable" => false
    },
    "create-durable-queue" => {
        "description" => "This permission allows the user to create a durable queue.",
        "type" => BOOLEAN,
        "nillable" => false
    },
    "delete-durable-queue" => {
        "description" => "This permission allows the user to delete a durable queue.",
        "type" => BOOLEAN,
        "nillable" => false
    },
    "create-non-durable-queue" => {
        "description" => "This permission allows the user to create a temporary queue.",
        "type" => BOOLEAN,
        "nillable" => false
    },
    "delete-non-durable-queue" => {
        "description" => "This permission allows the user to delete a temporary queue.",
        "type" => BOOLEAN,
        "nillable" => false
    },
    "manage" => {
        "description" => "This permission allows the user to invoke management operations by sending management messages to the management a
ddress.",
        "type" => BOOLEAN,
        "nillable" => false
    }
}
{code}

The attributes are actually fine, but I just noticed that in the new version you use defaults for non nillable attributes which sounds a bit strange to me. So the purpose of this JIRA is to get a fresh pair of eyes on this :-)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira