[jboss-jira] [JBoss JIRA] (AS7-5063) AS7 should pass the property "eclipselink.target-server = JBoss" to persistence providers, or at least EclipseLink

[Craig Ringer (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713520#comment-12713520 ] 

Craig Ringer edited comment on AS7-5063 at 8/24/12 5:51 AM:
------------------------------------------------------------

I'd be happy to contribute it, but most of the actual code was written by others, I just packaged it up into a self-contained module with a tool to auto-assemble an EclipseLink module and wrote the AS7 persistence unit integration skeleton. We'd need permission from Rich DiCroce (https://community.jboss.org/people/rcd), who wrote JBossArchiveFactoryImpl.java and VFSArchive.java. I don't know the origin of JBossLogger.java as Rich had already published it on his howto when I picked it up and packaged it; I presume that was Rich too.

As for the package name, embarrassingly it's wrong anyway; it should've been au.id.ringerc, so it's not exactly a hassle to change it.

I'll re-test auto-activation on the latest 7.2, but I already know part of why it wasn't working properly. It seems that EclipseLink can't accept eclipselink.archive.factory as an EntityManagerFactory parameter via PersistenceUnitProperties; it needs it to be a system property.
                
      was (Author: ringerc):
    I'd be happy to contribute it, but most of the actual code was written by others, I just packaged it up. We'd also need permission from Rich DiCroce (https://community.jboss.org/people/rcd), who wrote JBossArchiveFactoryImpl.java and VFSArchive.java. I don't know the origin of JBossLogger.java as Rich had already published it on his howto when I picked it up and packaged it.

As for the package name, embarrassingly it's wrong anyway; it should've been au.id.ringerc, so it's not exactly a hassle to change it.

I'll re-test auto-activation on the latest 7.2, but I already know part of why it wasn't working properly. It seems that EclipseLink can't accept eclipselink.archive.factory as an EntityManagerFactory parameter via PersistenceUnitProperties; it needs it to be a system property.
                  
> AS7 should pass the property "eclipselink.target-server = JBoss" to persistence providers, or at least EclipseLink
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-5063
>                 URL: https://issues.jboss.org/browse/AS7-5063
>             Project: Application Server 7
>          Issue Type: Enhancement
>          Components: JPA / Hibernate
>    Affects Versions: 7.1.1.Final
>            Reporter: Craig Ringer
>            Assignee: Scott Marlow
>            Priority: Minor
>              Labels: eclipselink, jpa
>             Fix For: 7.2.0.Alpha1
>
>
> For EclipseLink to properly identify the container and set up correct transaction integration, etc, it needs the property "eclipselink.target-server" to be set to "JBoss".
> There's an open issue asking EclipseLink to auto detect the container (https://bugs.eclipse.org/bugs/show_bug.cgi?id=383257) but right now, a simple solution to making EclipseLink work well on AS7 is for AS7 to pass that property to EclipseLink.
> That'll help prevent issues and confusion like this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=365704
> Users can set it as a system property right now as shown on bug 383257, but really it'd be best if JBoss passed it to the persistence unit during creation.
> Time permitting I'll give this a go.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira