[jboss-jira] [JBoss JIRA] (AS7-5063) AS7 should pass the property "eclipselink.target-server = JBoss" to persistence providers, or at least EclipseLink

[Craig Ringer (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714133#comment-12714133 ] 

Craig Ringer commented on AS7-5063:
-----------------------------------

I've signed the contributor agreement for my portion - which is really just the trivial adapter code in EclipseLinkPersistenceProviderAdaptor.java, the trivial module.xml, and the somewhat complicated Maven build that won't get used in AS7's build anyway.

I think the logging integration is vital. Without it AS7's logs are immensely spammy and really hard to manage. It can't really be pushed into EclipseLink's codebase, as (a) we've missed the 2.4 release window and (b) it depends on JBoss Logging, so it's no better to have it in EclipseLink than in AS7. I don't see a big problem with depending on the public EclipseLink logging classes, as they'll exist for at least the whole 2.4 series, and they're public API that isn't very likely to go away. If it does then - as with the Hibernate modules - the module might want to be split by version.

Bundling EclipseLink in the deployment is more of a problem. If EclipseLink is in the deployment, but no module for EclipseLink its self exists, it's my understanding that the integration would't find the EclipseLink logging classes when JBossLogger was instantiated by EclipseLink.

Is there any way to let the module see the application classpath so it can use the application's EclipseLink? And should it? What then happens if both an EclipseLink module and a bundled copy in an app are present?

How does this compare to other providers? If you bundle OpenJPA or Hibernate in your app?
                
> AS7 should pass the property "eclipselink.target-server = JBoss" to persistence providers, or at least EclipseLink
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-5063
>                 URL: https://issues.jboss.org/browse/AS7-5063
>             Project: Application Server 7
>          Issue Type: Enhancement
>          Components: JPA / Hibernate
>    Affects Versions: 7.1.1.Final
>            Reporter: Craig Ringer
>            Assignee: Scott Marlow
>            Priority: Minor
>              Labels: eclipselink, jpa
>             Fix For: 7.2.0.Alpha1
>
>
> For EclipseLink to properly identify the container and set up correct transaction integration, etc, it needs the property "eclipselink.target-server" to be set to "JBoss".
> There's an open issue asking EclipseLink to auto detect the container (https://bugs.eclipse.org/bugs/show_bug.cgi?id=383257) but right now, a simple solution to making EclipseLink work well on AS7 is for AS7 to pass that property to EclipseLink.
> That'll help prevent issues and confusion like this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=365704
> Users can set it as a system property right now as shown on bug 383257, but really it'd be best if JBoss passed it to the persistence unit during creation.
> Time permitting I'll give this a go.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira