[jboss-jira] [JBoss JIRA] (AS7-5063) AS7 should pass the property "eclipselink.target-server = JBoss" to persistence providers, or at least EclipseLink

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714136#comment-12714136 ] 

Scott Marlow commented on AS7-5063:
-----------------------------------

Regarding when EclipseLink jars are deployed with the application, that is the case where I want to remove static EclipseLink module references from the adaptor.

If you look in JPADependencyProcessor.addHibernate3AdaptorToDeployment(), we have a way of bringing the adapter classes into the application (currently only done for Hibernate 3.x persistence providers).  I started a branch for doing the same for other providers here https://github.com/scottmarlow/jboss-as/tree/AS7-5281_Hibernate4PackagedWithApp.  The next step is to remove static dependencies between the persistence provider adaptors and the modules that they depend on (how to best do this is open).

When we bring the EclipseLink adapter classes into the deployment, we also add the adapters dependencies to the application.  One of the dependencies will be the EclipseLink (static) module.  

One solution might be to change the methods in PersistenceProviderAdaptor to pass a helper parameter that can return the persistence provider class.  

I reopened AS7-5281 which goes with https://github.com/scottmarlow/jboss-as/tree/AS7-5281_Hibernate4PackagedWithApp.
                
> AS7 should pass the property "eclipselink.target-server = JBoss" to persistence providers, or at least EclipseLink
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-5063
>                 URL: https://issues.jboss.org/browse/AS7-5063
>             Project: Application Server 7
>          Issue Type: Enhancement
>          Components: JPA / Hibernate
>    Affects Versions: 7.1.1.Final
>            Reporter: Craig Ringer
>            Assignee: Scott Marlow
>            Priority: Minor
>              Labels: eclipselink, jpa
>             Fix For: 7.2.0.Alpha1
>
>
> For EclipseLink to properly identify the container and set up correct transaction integration, etc, it needs the property "eclipselink.target-server" to be set to "JBoss".
> There's an open issue asking EclipseLink to auto detect the container (https://bugs.eclipse.org/bugs/show_bug.cgi?id=383257) but right now, a simple solution to making EclipseLink work well on AS7 is for AS7 to pass that property to EclipseLink.
> That'll help prevent issues and confusion like this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=365704
> Users can set it as a system property right now as shown on bug 383257, but really it'd be best if JBoss passed it to the persistence unit during creation.
> Time permitting I'll give this a go.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira