[jboss-jira] [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name

[Geoffrey De Smet (JIRA)]

     [ https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoffrey De Smet resolved JBRULES-2438.
---------------------------------------

    Resolution: Done


Fixed decently on master by adding the sheet name to the rule name generation
                
> Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBRULES-2438
>                 URL: https://issues.jboss.org/browse/JBRULES-2438
>             Project: Drools
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: drools-core
>    Affects Versions: 5.0.1.FINAL
>            Reporter: Toshiya Kobayashi
>            Assignee: Geoffrey De Smet
>             Fix For: 5.5.0.Beta1
>
>
> I'm trying to use rules via DecisionTable using change-set.
> I wrote rules in multiple sheets of single Excel book.
> Then I configured my change-set xml like:
> ...
> <add>
> <resource source='classpath:data/dtable.xls' type="DTABLE">
> <decisiontable-conf input-type="XLS" worksheet-name="sheet1" />
> </resource>
> <resource source='classpath:data/dtable.xls' type="DTABLE">
> <decisiontable-conf input-type="XLS" worksheet-name="sheet2" />
> </resource>
> </add>
> ...
> But only rules of sheet1 were loaded.
> As far as I observed source codes, KnowledgeAgentImpl.java puts resource into "Map<Resource, ResourceMapping> resources". But even if multiple resources are configured in change-set, it appears to me like those resources are considered as the same resource and eventually only one resource will be registered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira