[jboss-jira] [JBoss JIRA] (AS7-5995) After deploy an application with a wrong module slot dependency the module loader does not recover

[Chao Wang (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739168#comment-12739168 ] 

Chao Wang commented on AS7-5995:
--------------------------------

We want to remove the dynamic module *deployment.TestCustomModule.war* , there is one named "unloadModuleLocal(Module module)" in the ModuleLoader class from jboss-module. 

Unfortunately, this is an unsuccessful deployed module, we can't reference any module type.  

One idea is that we add one method as follow example who allow to remove futureModule from moduleMap by identifier, then in as7, we can call it from ModuleLoadService.start() before throw an exception.


{code:xml}
    protected final void unloadModuleLocalByIdentifier(ModuleIdentifier identifier) throws ModuleLoadException {
    	
        final ModuleIdentifier id = identifier;
        final FutureModule futureModule = moduleMap.get(id);
        if(futureModule == null)
        	throw new ModuleLoadException("No futureModule was found in the moduleMap with the identifier "+ id);
        else
            moduleMap.remove(id, futureModule);
    }
{code} 
                
> After deploy an application with a wrong module slot dependency the module loader does not recover
> --------------------------------------------------------------------------------------------------
>
>                 Key: AS7-5995
>                 URL: https://issues.jboss.org/browse/AS7-5995
>             Project: Application Server 7
>          Issue Type: Bug
>    Affects Versions: 7.2.0.Alpha1
>         Environment: Tested with 7.2. upstream
> commit ed2bc551a55ec6a8167a8657cbb5d8abc6e07748
> Date:   Thu Nov 15 10:15:22 2012 +0100
> standalone mode, no difference whether CLI or file-system scanner
>            Reporter: Wolf-Dieter Fink
>            Assignee: Chao Wang
>              Labels: dependency, modules
>         Attachments: server.log, server.log
>
>
> If an application is deployed with a dependency and specify a slot in jboss-deployment-structure.xml:
>   <module name="wfink.tools.performance" slot="1.0" export="true"/>
> the module loader will not correct load a new deployment after failing with 'JBAS018759' Caused by: org.jboss.modules.ModuleNotFoundException: Module wfink.tools.performance:1.1 is not found in local module loader.
> If after such message the application.ear contain a correct slot, or even no slot entry, the module loader fail with the message above. The slot number is the same as of the failed deployment.
> If the server is restarted the application deploy succeeds.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira