[jboss-jira] [JBoss JIRA] (AS7-6103) ServiceModuleLoader can't properly unload module if it failed to load module due to wrong dependency

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/AS7-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740646#comment-12740646 ] 

David Lloyd commented on AS7-6103:
----------------------------------

I do think you should ensure that the returned module isn't null though.
                
> ServiceModuleLoader can't properly unload module if it failed to load module due to wrong dependency
> ----------------------------------------------------------------------------------------------------
>
>                 Key: AS7-6103
>                 URL: https://issues.jboss.org/browse/AS7-6103
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 7.2.0.Alpha1
>            Reporter: Chao Wang
>            Assignee: Chao Wang
>            Priority: Critical
>              Labels: dependency, modules
>         Attachments: AS7-6103.patch
>
>
> ServiceModuleLoader can't properly unload module if it failed to load module due to wrong dependency.
> The codes below take care of unload operation.
> {code:title=org.jboss.as.server.moduleservice.ServiceModuleLoader.java|borderStyle=solid}
> case STOP_REQUESTED_to_STOPPING: {
>   log.tracef("serviceStopping: %s", controller);
>   ModuleSpec moduleSpec = this.moduleSpec;
>   try {
>       *Module module = loadModule(moduleSpec.getModuleIdentifier());*
>       *unloadModuleLocal(module);*
>   } catch (ModuleLoadException e) {
>       // ignore, the module should always be already loaded by this point,
>       // and if not we will only mask the true problem
>   }
>       // TODO: what if the service is restarted?
>     controller.removeListener(this);
>     break;
> }
> {code}
> The line *unloadModuleLocal(module)* can not be reached because the previous loadModule(moduleSpec.getModuleIdentifier() will throw ModuleLoadException if module has dependency problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira