[jboss-jira] [JBoss JIRA] (AS7-6104) jboss-cli failed to remove PostgreSQL datasource module NullPointerException OperationContextImpl.doRemove()

Thu Dec 13 10:50:17 EST 2012

    [ https://issues.jboss.org/browse/AS7-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741274#comment-12741274 ] 

Stefano Maestri commented on AS7-6104:
--------------------------------------

<maeste2> bstansberry: wprking on AS7-6104
<jbossbot> jira [AS7-6104] jboss-cli failed to remove PostgreSQL datasource module NullPointerException OperationContextImpl.doRemove() [Open (Unresolved) Bug, Major, Stefano Maestri] https://issues.jboss.org/browse/AS7-6104
<maeste2> bstansberry: the problem is different there
<maeste2> bstansberry: it correctly fail operation
<maeste2> bstansberry: add operation
<maeste2> bstansberry: but when server is booting I see failure in log, but resource is added even if runtime part is rolled back
* hbraun has quit (Quit: hbraun)
<maeste2> bstansberry: it doesn't happen in normal mode
<maeste2> bstansberry: have you an explanation for that? Or is it something I have to seek in my code
<bstansberry> maeste2: the runtime part doesn't roll back on boot
<bstansberry> maeste2: I wish we did, but we don't rollback on runtime failures in boot
<maeste2> bstansberry: ok, so the problem is not in my code itself, it's a more general behaviour, right?
* pferraro (~paul at c-71-235-89-202.hsd1.ct.comcast.net) has joined #jboss-as7
* bstansberry is looking
<maeste2> bstansberry: because I'm failing in :remove action if the runtime of add isn't completed correctly
<maeste2> bstansberry: I get null for a service lookup
<bstansberry> maeste2: with the stack trace shown in the JIRA?
<maeste2> bstansberry: but in general we should not add the resource
<maeste2> bstansberry: yup exactly
<maeste2> bstansberry: users see the NPE for remove, because they are removing a resource not started correctly
<maeste2> bstansberry: in particular it's a driver refering to non existing module
<bstansberry> maeste2: ok, assign that to me; removeService shouldn't throw an NPE
* ssadeghi has quit (Ping timeout: 250 seconds)
<maeste2> bstansberry: oki, feel free to ping me if I can help in any way of course
<maeste2> bstansberry: can we discuss also AS7-5472
<jbossbot> jira [AS7-5472] unavailable datasource statistics [Open (Unresolved) Bug, Minor, Stefano Maestri] https://issues.jboss.org/browse/AS7-5472
<bstansberry> maeste2: the OSH should always check for null before invoking on the ServiceController, but you shouldn't have to null check before calling removeService

> jboss-cli failed to remove PostgreSQL datasource module NullPointerException OperationContextImpl.doRemove()
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-6104
>                 URL: https://issues.jboss.org/browse/AS7-6104
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Domain Management, JCA
>    Affects Versions: 7.1.1.Final
>         Environment: Windows 7 Professional SP1
>            Reporter: Raymond Naseef
>            Assignee: Brian Stansberry
>              Labels: jboss-as7, modules, postgresql
>
> NullPointerException during jboss-cli remove with command:
>     jboss-cli --connect command="/subsystem=datasources/jdbc-driver=bop:remove"
> Console and log below.
> This happens when standalone.xml has XML entry for driver that does not exist (see "Steps to Reproduce").  I have also seen this happen in a case where the driver does exist; not sure how the latter happened, or how important that is.
> MS-DOS Console:
> {
>     "outcome" => "failed",
>     "failure-description" => "JBAS014749: Operation handler failed: null",
>     "rolled-back" => true
> }
> Server Log:
> 23:17:42,627 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 19) JBAS014612: Operation ("remove") failed - address: ([
>     ("subsystem" => "datasources"),
>     ("jdbc-driver" => "postgresql-driver")
> ]): java.lang.NullPointerException
> 	at org.jboss.as.controller.OperationContextImpl.doRemove(OperationContextImpl.java:298) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.OperationContextImpl.removeService(OperationContextImpl.java:293) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.connector.subsystems.datasources.JdbcDriverRemove.performRuntime(JdbcDriverRemove.java:66)
> 	at org.jboss.as.controller.AbstractRemoveStepHandler$1.execute(AbstractRemoveStepHandler.java:50) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:385) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.AbstractOperationContext.doCompleteStep(AbstractOperationContext.java:272) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.AbstractOperationContext.completeStep(AbstractOperationContext.java:200) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.ModelControllerImpl$DefaultPrepareStepHandler.execute(ModelControllerImpl.java:466) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:385) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.AbstractOperationContext.doCompleteStep(AbstractOperationContext.java:272) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.AbstractOperationContext.completeStep(AbstractOperationContext.java:200) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:121) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.doExecute(ModelControllerClientOperationHandler.java:139) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1.execute(ModelControllerClientOperationHandler.java:108) [jboss-as-controller-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.protocol.mgmt.AbstractMessageHandler$2$1.doExecute(AbstractMessageHandler.java:287) [jboss-as-protocol-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.as.protocol.mgmt.AbstractMessageHandler$AsyncTaskRunner.run(AbstractMessageHandler.java:487) [jboss-as-protocol-7.1.1.Final.jar:7.1.1.Final]
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) [rt.jar:1.7.0]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) [rt.jar:1.7.0]
> 	at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0]
> 	at org.jboss.threads.JBossThread.run(JBossThread.java:122) [jboss-threads-2.0.0.GA.jar:2.0.0.GA]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira