[jboss-jira] [JBoss JIRA] (AS7-6082) EJbLogger contains messages that should be in EjbMessages

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/AS7-6082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742750#comment-12742750 ] 

Brian Stansberry commented on AS7-6082:
---------------------------------------

Be careful about the message ids on this. Make sure that any gaps in the numerically ordered message sequence in EjbLogger have comments so no one comes along and reuses the old code for a new message. Simplest is just to comment out the old code to leave a trail.

If the old ids from EjbLogger are still used in EjbMessages (which IMO should be what is done so any existing knowledge base articles keyed by the old id don't get orphaned), make sure that the formerly-EjbLogger methods appear in the correct sequence in the file.  Be careful about having the last message in the file using a "logger" id; if that happens but a big bold comment after it so people don't accidentally use a "logger" id for the next method they add.
                
> EJbLogger contains messages that should be in EjbMessages
> ---------------------------------------------------------
>
>                 Key: AS7-6082
>                 URL: https://issues.jboss.org/browse/AS7-6082
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: EJB
>            Reporter: Stuart Douglas
>            Assignee: Eduardo Martins
>            Priority: Minor
>
> The EjbLogger class also contains exception messages, not just log messages. 
> It also has two loggers (ROOT_LOGGER and EJB3_LOGGER) with the same package name, it would be good to get rid of one of them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira