[jboss-jira] [JBoss JIRA] (AS7-6251) SimpleAttributeDefinition BACKGROUNDVALIDATIONMILLIS defined incompatible ModelType and ParameterValidator

[Chao Wang (JIRA)]

    [ https://issues.jboss.org/browse/AS7-6251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743046#comment-12743046 ] 

Chao Wang commented on AS7-6251:
--------------------------------

hi [~jalpedersen] why we use a different LONG type here?
I'm seeing this issue will fail the test ComplexDatasourceSubsystemTestCase when I tried to find a solution for AS7-6139 to strictly check the numeric value in ModelTypeValidator, and avoid the validation case like ModelNode(Long.MAX_LONG).asInt()
                
> SimpleAttributeDefinition BACKGROUNDVALIDATIONMILLIS defined incompatible ModelType and ParameterValidator
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-6251
>                 URL: https://issues.jboss.org/browse/AS7-6251
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: JCA
>    Affects Versions: 7.1.3.Final (EAP)
>            Reporter: Chao Wang
>            Assignee: Chao Wang
>            Priority: Minor
>
> The SimpleAttributeDefinition BACKGROUNDVALIDATIONMILLIS is defined : 
> {code:title=org.jboss.as.connector.subsystems.common.pool.Constants.java|borderStyle=solid}
> public static final SimpleAttributeDefinition BACKGROUNDVALIDATIONMILLIS = new SimpleAttributeDefinition(BACKGROUNDVALIDATIONMILLIS_NAME, Validation.Tag.BACKGROUND_VALIDATION_MILLIS.getLocalName(),  new ModelNode(), ModelType.LONG, true, true, MeasurementUnit.MILLISECONDS, new IntRangeValidator(1, true, true));
> {code} 
> The ModelType should be an integer value as defined in jboss-as-datasources_1_1.xsd:
> {code:xml}
> <xs:element name="background-validation-millis" type="xs:nonNegativeInteger" minOccurs="0">
>         <xs:annotation>
>           <xs:documentation>
>             <![CDATA[[
>               The background-validation-millis element specifies the amount of
>               time, in millis, that background validation will run.
>              ]]>
>           </xs:documentation>
>         </xs:annotation>
> </xs:element>
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira