[jboss-jira] [JBoss JIRA] (JGRP-1559) FD: monitor task sometimes isn't running

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743054#comment-12743054 ] 

Bela Ban edited comment on JGRP-1559 at 12/28/12 11:29 AM:
-----------------------------------------------------------

I changed the logic slightly:
- The monitor task is running when the membership is 2 or greater and it stops when the membership drops below
- There's 1 method (computePingDest()) which sets pingable_mbrs and ping_dest
- The monitor task doesn't do anything if ping_dest is null

This ensures that the monitor task is always running and a temporary null ping_dest doesn't cause it to stop.
                
      was (Author: belaban):
    I changed the logic slightly:
- The monitor task is running when the membership is 2 or greater and it stops when the membership drops below
- There's 1 method (computePingDest()) which sets pingable_mbrs and ping_dest
- The monitor task doesn't do anything if ping_dest is null
                  
> FD: monitor task sometimes isn't running
> ----------------------------------------
>
>                 Key: JGRP-1559
>                 URL: https://issues.jboss.org/browse/JGRP-1559
>             Project: JGroups
>          Issue Type: Feature Request
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>             Fix For: 3.2.6, 3.3
>
>
> FD.isMonitorRunning() is sometimes false even when the membership is > 1. Probable cause is restartMonitor() will stops the running monitor, but doesn't start a new one if ping_dest == null.
> Need to investigate concurrent updates to pingable_mbrs and ping_dest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira