[jboss-jira] [JBoss JIRA] (AS7-3478) read-operation-description incorrect for distributed-cache

[Richard Achmatowicz (JIRA)]

    [ https://issues.jboss.org/browse/AS7-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664798#comment-12664798 ] 

Richard Achmatowicz commented on AS7-3478:
------------------------------------------

I revisited this solution and corrected the following:

- eliminated definition of two keys (involving CACHE_MODE and MODE and the ShareableNameAttributeDefinition) and more simply moved the MODE definition for cache mode to a separate file so that I could avoid the scoping conflict and retain use of the two instances of MODE. Now, CommonAttributes.MODE holds the transaction mode definition, and ClusteredCacheAdd.MODE holds the cache mode definition, and the use of CACHE_MODE is eliminated. 

- used EnumValidator for all enums in the Infinispan subsystem, which include:
StartMode (EAGER, LAZY)
IsolationLevel (REPEATABLE_READ, ...)
TransactionMode (NONE, NON_XA, NON_DURABLE,...)
EvictionStrategy (NONE, UNORDERDED, FIFO, ...) 
Indexing (NONE, LOCAL, ALL)
Mode (ASYNC, SYNC)


                
> read-operation-description incorrect for distributed-cache
> ----------------------------------------------------------
>
>                 Key: AS7-3478
>                 URL: https://issues.jboss.org/browse/AS7-3478
>             Project: Application Server 7
>          Issue Type: Bug
>            Reporter: Stan Silvert
>            Assignee: Richard Achmatowicz
>
> {noformat}
> /subsystem=infinispan/cache-container=hibernate/distributed-cache=distributed/:add(batching=false)
> {
>     "outcome" => "failed",
>     "failure-description" => "JBAS014749: Operation handler failed: No child 'mode' exists",
>     "rolled-back" => true,
>     "response-headers" => {"process-state" => "reload-required"}
> }
> {noformat}
> read-operation-description doesn't show "mode" as a required field and it doesn't restrict its values with "allowed"
> {noformat}
> /subsystem=infinispan/cache-container=hibernate/distributed-cache=*/:read-operation-description(name=add)
> {
>     "outcome" => "success",
>     "result" => {
>         "operation-name" => "add",
>         "description" => "Add a distributed cache to this cache container",
>         "request-properties" => {
>             ...
>             "mode" => {
>                 "type" => STRING,
>                 "description" => "Sets the clustered cache mode, ASYNC for asynchronous operation, or SYNC for synchronous operation.",
>                 "expressions-allowed" => false,
>                 "required" => false,
>                 "nillable" => true,
>                 "min-length" => 1L,
>                 "max-length" => 2147483647L
>             },
>             ...
>         }
> }
> {noformat}
> It should be:
> {noformat}
>             "mode" => {
>                 "type" => STRING,
>                 "description" => "Sets the clustered cache mode, ASYNC for asynchronous operation, or SYNC for synchronous operation.",
>                 "expressions-allowed" => false,
>                 "required" => true,
>                 "nillable" => true,
>                 "min-length" => 1L,
>                 "max-length" => 2147483647L
>                 "allowed" => [
>                   "ASYNC",
>                   "SYNC"
>                ]
>             },
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira