[jboss-jira] [JBoss JIRA] (AS7-1893) JDBC cache store configuration improvements

[Richard Achmatowicz (JIRA)]

    [ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671073#comment-12671073 ] 

Richard Achmatowicz commented on AS7-1893:
------------------------------------------

Manik, Paul

Tristan set up the JDBC store configuration in such a way that:
- if you define an entry table only, you get a string based store
- if you define a bucket table only, you get a binary based store
- if you define both types of tables, you get a mixed store

I assume you would rather see something which makes the creation of the different types of stores more explicit, such as:
{noformat}
<!-- define a string-based store -->
<string-keyed-jdbc-store fetch-state= passivation= preload= purge= shared= singleton= >
  <string-keyed-table ...>
     ...
  </string-keyed-table>
<string-keyed-jdbc-store>

<!-- define a binary-based store -->
<binary-keyed-jdbc-store fetch-state= passivation= preload= purge= shared= singleton= >
  <binary-keyed-table ...>
     ...
  </binary-keyed-table>
<binary-keyed-jdbc-store>

<!-- define a mixed store -->
<mixed-keyed-jdbc-store fetch-state= passivation= preload= purge= shared= singleton= >
  <string-keyed-table ...>
     ...
  </string-keyed-table>
  <binary-keyed-table ...>
     ...
  </binary-keyed-table>
<mixed-keyed-jdbc-store>
{noformat}

As you point out, in the current implementation, one can specify specific details for the underlying database tables, such as column names and column types, and table name prefixes. When you say that the current implementation exposes implementation details, do you mean that you simply want to change the names so that we aren't tied to a particular implementation, but keep the underlying implementation the same (i.e. get rid of the word bucket-table and replace it with binary-keyed-table, but use a bucket-based cache store anyway).

Also, is the exposure to TableManipulation attributes ok as is?
 
 
                
> JDBC cache store configuration improvements
> -------------------------------------------
>
>                 Key: AS7-1893
>                 URL: https://issues.jboss.org/browse/AS7-1893
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: Clustering
>            Reporter: Manik Surtani
>            Assignee: Richard Achmatowicz
>             Fix For: 7.1.2.Final
>
>
> The current <jdbc-store ...> element isn't quite explicit enough to differentiate between the 3 types of JDBC cache stores Infinispan has to offer.  <string-keyed-jdbc-store ... >, <binary-keyed-jdbc-store ... > and <mixed-keyed-jdbc-store ... > may be better.  Similarly, <bucket-table> and <entry-table> expose implementation details. <binary-keyed-table ...> and <string-keyed-table ... > may be better.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira