[jboss-jira] [JBoss JIRA] (JBRULES-3334) AbstractTabuAcceptor doesn't add the starting solution as tabu

[Patrik Dufresne (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBRULES-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654480#comment-12654480 ] 

Patrik Dufresne commented on JBRULES-3334:
------------------------------------------

When adding the first solution to the tabu-map, I'm wondering what Index value I should provide since a value of 0 represent the first step. The Index -1 is used to represent a 'not found' tabu. Without major change, I think the best is to put the first solution with Index 0. The tabu-map will then have two solutions with the same index value : the first solution and the step 0 solution.

I've create a pull request, not sure I've done it right. It's my first time with github.
                
> AbstractTabuAcceptor doesn't add the starting solution as tabu
> --------------------------------------------------------------
>
>                 Key: JBRULES-3334
>                 URL: https://issues.jboss.org/browse/JBRULES-3334
>             Project: Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: drools-planner
>    Affects Versions: 5.3.1.Final
>            Reporter: Patrik Dufresne
>            Assignee: Geoffrey De Smet
>
> When setting a complete solution tabu, the starting solution is not considered a Tabu making it possible to visit the same solution again.
> Consider a situation where there is construction phase followed by a local search phase. The construction phase will create a solution that will not be added to the tabu list of the local search phased.
> To fix it, I suggest to override the function phaseStarted(...) in SolutionTabuAcceptor to add solution to the Tabu map.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira