[jboss-jira] [JBoss JIRA] (AS7-3169) Admin console: missing validation on JVM arguments

[Jan Martiska (JIRA)]

    [ https://issues.jboss.org/browse/AS7-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659172#comment-12659172 ] 

Jan Martiska commented on AS7-3169:
-----------------------------------

"man java" says:

-Xmsn
                Specify the initial size, in bytes, of the memory allocation
                pool. This value must be a multiple of 1024 greater than 1MB.
                Append the letter k or K to indicate kilobytes, or m or M to
                indicate megabytes. The default value is chosen at runtime
                based on system configuration. For more information, see
                HotSpot Ergonomics
                Examples:

                       -Xms6291456
                       -Xms6144k
                       -Xms6m

so it is quite tricky, but I would recommend somehow to stick to this definition to find out which values will not cause an error when trying to boot up a server. It could also be useful to add some better description to the help (the question mark in the page).

I guess the "multiple of 1024" requirement is not rigorous, at least sun java 6 doesn't require it, but the minimum of 1 MB (initial size) / 2 MB (maximum size) is indeed required. Anyway we should not allow such low values, because the server wouldn't boot up anyway :) there should be some sort of hint for the user, what the recommended heap size for AS is.
                
> Admin console: missing validation on JVM arguments
> --------------------------------------------------
>
>                 Key: AS7-3169
>                 URL: https://issues.jboss.org/browse/AS7-3169
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Console
>    Affects Versions: 7.1.0.CR1b
>            Reporter: Jan Martiska
>            Assignee: Pavel Slegr
>            Priority: Critical
>         Attachments: jvmargs.png
>
>
> It is currently possible to set invalid JVM arguments for a server instance or group, as seen in the attached screenshot. The input field designating heap size and maximum heap size should be somehow reworked, made more intuitive, at least the help should show more information on what you can put in. If you enter an invalid value, the operation will succeed, the invalid value will be used after the domain is restarted, and causing related servers to NOT BOOT UP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira