[jboss-jira] [JBoss JIRA] (AS7-2392) EnterpriseDeploymentTestCase fails consistently on windows

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/AS7-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659275#comment-12659275 ] 

Brian Stansberry commented on AS7-2392:
---------------------------------------

I haven't had time to really attack this yet; just doing some investigation. So these are notes to self or in case I assign this to someone else:

After a quick look it seems the logic to close streams we open only happens if there is some sort of error condition. It happens in the DeploymentPlanBuilderImpl.cleanup() method and that seems to only get called in case of failure.

If ^^^ is correct, a fix would require that we:

1) Call cleanup() in a finalizer method for the DPBI.
2) More critically, make sure that if build() is called, the resulting DeploymentPlan closes the streams. Once build() is called, the streams are "owned" by the DeploymentPlan.
3) The DeploymentPlan should also do cleanup in a finalizer. But that should be a final line of defense; the main solution to 2) should be doing cleanup as soon as the plan is executed.
                
> EnterpriseDeploymentTestCase fails consistently on windows
> ----------------------------------------------------------
>
>                 Key: AS7-2392
>                 URL: https://issues.jboss.org/browse/AS7-2392
>             Project: Application Server 7
>          Issue Type: Task
>          Components: Domain Management, JSR88
>         Environment: win7
>            Reporter: Dimitris Andreadis
>            Assignee: Brian Stansberry
>            Priority: Critical
>             Fix For: 7.1.0.Final
>
>         Attachments: TEST-org.jboss.as.test.smoke.embedded.deployment.EnterpriseDeploymentTestCase.xml
>
>
> I get there consistent test failures on win7 in the integration testsuite:
> {code}
> Failed tests:   testDistributeEjbApp(org.jboss.as.test.smoke.embedded.deployment.EnterpriseDeploymentTestCase): expected:<Completed> but was:<Failed>
>   testDistributeEARApp(org.jboss.as.test.smoke.embedded.deployment.EnterpriseDeploymentTestCase): expected:<Completed> but was:<Failed>
>   testListAvailableModules(org.jboss.as.test.smoke.embedded.deployment.EnterpriseDeploymentTestCase)
> By looking in the logs, I think the problem is traced back to this deployment problem that affects all failures:
> Caused by: java.lang.RuntimeException: Could not create timer file store directory X:\src\jboss-as\testsuite\integration\target\smoke\standalone\data\timer-service-data\file:\C:\Users\dimitris\AppData\Local\Temp\deployment-ejb.jar
> 	at org.jboss.as.ejb3.timerservice.mk2.persistence.filestore.FileTimerPersistence.start(FileTimerPersistence.java:101)
> 	at org.jboss.as.ejb3.timerservice.TimerServiceFactoryService.start(TimerServiceFactoryService.java:77)
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1824) [jboss-msc-1.0.1.GA.jar:1.0.1.GA]
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1759) [jboss-msc-1.0.1.GA.jar:1.0.1.GA]
> 	... 3 more
> {code}
> It concatenates the testsuite target dir with the user's temp dir.?
> Looking quickly I couldn't find where the path to this file is created. Maybe it's a ShrinkWrap issue?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira