[jboss-jira] [JBoss JIRA] (JBRULES-3351) Settings a termination config list will not create the Termination instance

[Geoffrey De Smet (JIRA)]

     [ https://issues.jboss.org/browse/JBRULES-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoffrey De Smet resolved JBRULES-3351.
---------------------------------------

    Fix Version/s: 5.4.0.Beta2
       Resolution: Done


Good catch, thanks for reporting!

Tip: use {code} tags in jira to format code :)
                
> Settings a termination config list will not create the Termination instance
> ---------------------------------------------------------------------------
>
>                 Key: JBRULES-3351
>                 URL: https://issues.jboss.org/browse/JBRULES-3351
>             Project: Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: drools-planner
>    Affects Versions: 5.3.1.Final
>         Environment: N/A
>            Reporter: Patrik Dufresne
>            Assignee: Geoffrey De Smet
>             Fix For: 5.4.0.Beta2
>
>
> Setting a sub termination config list using TerminationConfig.setTerminationConfigList(List<TerminationConfig>) will not create the termination when buildTermination is called. The problem is due to an error in TerminationConfig.java:179.
>         if (terminationConfigList != null && terminationConfigList.isEmpty()) {
>             for (TerminationConfig terminationConfig : terminationConfigList) {
>                 Termination termination = terminationConfig.buildTermination(scoreDefinition);
>                 if (termination != null) {
>                     terminationList.add(termination);
>                 }
>             }
>         }
> The boolean expression terminationConfigList.isEmpty() should become !terminationConfigList.isEmpty().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira