[jboss-jira] [JBoss JIRA] (JBRULES-3352) Add the possibility to add an instance of Termination to the TerminationConfig

[Geoffrey De Smet (JIRA)]

     [ https://issues.jboss.org/browse/JBRULES-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoffrey De Smet resolved JBRULES-3352.
---------------------------------------

    Fix Version/s: 5.4.0.Beta2
       Resolution: Rejected


Rejected, the proper way to do this functionality is to extend TerminationConfig:
http://docs.jboss.org/drools/release/5.4.0.Beta1/drools-planner-docs/html_single/index.html#d0e4297

The problem with direct injects of Termination is that such a configuration isn't serializable to XML file properly and doesn't allow to reuse the same SolverFactory to create a new Solver safely (as the same Termination instance is used).
                
> Add the possibility to add an instance of Termination to the TerminationConfig
> ------------------------------------------------------------------------------
>
>                 Key: JBRULES-3352
>                 URL: https://issues.jboss.org/browse/JBRULES-3352
>             Project: Drools
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: drools-planner
>    Affects Versions: 5.3.1.Final
>         Environment: N/A
>            Reporter: Patrik Dufresne
>            Assignee: Geoffrey De Smet
>             Fix For: 5.4.0.Beta2
>
>
> The TerminationConfig class doesn't allow the user to sets a custom instance of a Termination. The only function available is to sets a Termination class using TerminationConfig.setTerminationClass(Class<Termination>). The user is then limited to provide a custom termination class that doesn't required any settings. (i.e.: it's not possible to have a Termination with a constructor requiring arguments)
> I suggest to add a function similar to other configuration class. e.g.: TerminationConfig.setTermination(Termination) and TerminationConfig.getTermination()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira