[jboss-jira] [JBoss JIRA] (AS7-2933) Regression: WebMetaDataParser gives error on war with no version info in web.xml

[Jason Greene (JIRA)]

     [ https://issues.jboss.org/browse/AS7-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Greene updated AS7-2933:
------------------------------


Please punt any of these that you dont plan on doing to 7.1.1
                
> Regression: WebMetaDataParser gives error on war with no version info in web.xml
> --------------------------------------------------------------------------------
>
>                 Key: AS7-2933
>                 URL: https://issues.jboss.org/browse/AS7-2933
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Web
>            Reporter: Kabir Khan
>            Assignee: Jean-Frederic Clere
>             Fix For: 7.1.0.Final
>
>
> To play with the deployment subsystem I normally deploy http://gwt-examples.googlecode.com/files/Calendar.war, which has no version info in its web.xml:
> {code}
> $unzip -p ~/temp/Calendar.war WEB-INF/web.xml
> <?xml version="1.0" encoding="ISO-8859-1"?>
> <web-app>
> <display-name>gwt-Calendar Compiled: Sun Jan 27 06:17:26 GMT 2008</display-name>
> <description>Google Web Toolkit Project</description>
> </web-app>
> {code}
> After https://github.com/jbossas/jboss-as/commit/977c1dd3c1717f53d96ae7dce32154417ce2daaf I see this error when deploying that war
> {code}
> 16:35:07,788 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-1) Starting deployment of "Calendar.war"
> 16:35:08,023 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-4) MSC00001: Failed to start service jboss.deployment.unit."Calendar.war".PARSE: org.jboss.msc.service.StartException in service jboss.deployment.unit."Calendar.war".PARSE: Failed to process phase PARSE of deployment "Calendar.war"
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:121) [jboss-as-server-7.1.0.CR1-SNAPSHOT.jar:]
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1824) [jboss-msc-1.0.1.GA.jar:]
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1759) [jboss-msc-1.0.1.GA.jar:]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [:1.6.0_29]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [:1.6.0_29]
> 	at java.lang.Thread.run(Thread.java:680) [:1.6.0_29]
> Caused by: java.lang.IllegalStateException: Cannot obtain servlet version
> 	at org.jboss.metadata.parser.servlet.WebMetaDataParser.parse(WebMetaDataParser.java:103)
> 	at org.jboss.metadata.parser.servlet.WebMetaDataParser.parse(WebMetaDataParser.java:54)
> 	at org.jboss.as.web.deployment.WebParsingDeploymentProcessor.deploy(WebParsingDeploymentProcessor.java:87)
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:115) [jboss-as-server-7.1.0.CR1-SNAPSHOT.jar:]
> 	... 5 more
> {code}
> A test should be added with a similar web.xml to guard against this in future

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira