[jboss-jira] [JBoss JIRA] (JBRULES-3355) Problems when writing rhs in Rule API

[RH Bugzilla Integration (JIRA)]

    [ https://issues.jboss.org/browse/JBRULES-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663056#comment-12663056 ] 

RH Bugzilla Integration commented on JBRULES-3355:
--------------------------------------------------

Edson Tirelli <etirelli at redhat.com> made a comment on [bug 728168|https://bugzilla.redhat.com/show_bug.cgi?id=728168]

Tomas, I just tested it myself and my previous comment holds. The problem you see with the use of # is a different problem. The error message says it:

"no viable alternative at character '#'"

The issue here is that when using the API, people are required to use valid java/mvel code blocks as the DRL parser is not used to deal with syntax sugar like #.

On top of that, we are deprecating # as that character might be required in the future to support other features and we don't want it to clash. So I don't think we should "fix" this. Instead, documenting it as deprecated as a whole and stating that when using the API, valid java/MVEL code has to be used is probably a better solution.

What do you think?
                
> Problems when writing rhs in Rule API
> -------------------------------------
>
>                 Key: JBRULES-3355
>                 URL: https://issues.jboss.org/browse/JBRULES-3355
>             Project: Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: drools-compiler
>    Affects Versions: 5.3.1.Final, 5.4.0.Beta1
>            Reporter: Edson Tirelli
>            Assignee: Edson Tirelli
>             Fix For: 5.3.2.Final, 5.4.0.Beta2
>
>
> Description of problem:
> There are several problems when writing rhs of a rule in Rule API:
> - if you omit rhs() you 'nullend' on the end of the rule which results in
> compile error
> - if you put comment in rhs() like rhs("//consequences") you get
> '//consequencesend' which result in compile error as well
> I think there should be line delimiter behind rhs and that if rhs is omitted it
> should result in empty string rather than "null".
> KnowledgeDescr descr = DescrFactory.newPackage().name("org.sample")
> .newRule().name("results in consequencesend")
>   .rhs("//consequences")
> .end()
> .newRule().name("results in nullend")
>   .lhs()
>     .pattern("String").end()
>   .end()
> .end()
> .getDescr();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira