[jboss-jira] [JBoss JIRA] (AS7-5010) Stack overflow in management API with many Bundles deployed

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704154#comment-12704154 ] 

Brian Stansberry commented on AS7-5010:
---------------------------------------

Good question.

In handleRollback() you shouldn't do anything that you wouldn't have done in the old variant. So, if you had this:

if (context.completeStep() == ResultAction.ROLLBACK) {
  doRollbackStuff(context, model);
}

then you would do:

context.completeStep(new OperationContext.RollbackHandler() {
  public void handleRollback(OperationContext context, ModelNode operation) {
      doRollbackStuff(context, model);
  }
});

But, if you didn't check the result of the old no-arg variant and then do something to roll back, then, just do this:

context.completeStep(OperationContext.RollbackHandler.NO_OP_ROLLBACK_HANDLER);

Now, as to your specific example, your rollback logic is restoring the persistent model to its old state. You never need to do that, because the way operations work is all changes to the model are made to a copy of the model, and only if the op isn't ResultAction.ROLLBACK will that modified model be published. If the op rolls back, that modified model is just discarded, so there is no need to restore its state.
                
> Stack overflow in management API with many Bundles deployed
> -----------------------------------------------------------
>
>                 Key: AS7-5010
>                 URL: https://issues.jboss.org/browse/AS7-5010
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Domain Management, OSGi
>    Affects Versions: 7.1.1.Final
>            Reporter: Thomas Diesler
>            Assignee: David Bosschaert
>             Fix For: 7.2.0.Alpha1
>
>
> Bernd says
> {quote}
> My Java 7 JVM is crashing in a Stack Overflow (which is a Bug initself). But while inspecting the hs_err file (attached) I noticed that the OSGi Parser has a extremly deep stack. I wonder if this is a endless loop bug or if it is caused by the many OSGi modules I have deployed in this 7.1.1.final AS7.
> I am not entirely shure what triggered the problem, at is happening after startup. But I think it was related with clicking the OSGi Runtime Management in the JBoss Managagement Console. There are roughly 250 bundles in the deployment list of the server group.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira