[jboss-jira] [JBoss JIRA] (AS7-3987) Replace jboss.dist with jboss.home for testsuite and other usage
Paul Gier (JIRA)
jira-events at lists.jboss.org
Sun Jul 29 12:15:08 EDT 2012
[ https://issues.jboss.org/browse/AS7-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708626#comment-12708626 ]
Paul Gier commented on AS7-3987:
--------------------------------
{quote}Paul, they are never the same. jboss.dist is copied to target/jbossas[-*], and the tests run there.{quote}
By default they are set to the same value in testsuite/pom.xml
{code:xml}
<jboss.dist>${project.basedir}/../build/target/jboss-as-${jboss.as.release.version}</jboss.dist>
<jboss.home>${jboss.dist}</jboss.home>
{code}
The same default location is hardcoded in arquillian poms
{code:xml}
<properties>
<jboss.home>${project.basedir}/../../build/target/jboss-as-${jboss.as.release.version}</jboss.home>
</properties>
{code}
So they appear to be the same unless you override the default values. My use case is that we need to change this default path for EAP, so I'm trying to avoid having multiple places where this path needs to be changed. This broke testsuite runs in the past when not all of the values were updated. My suggestion would be to move the jboss.dist property to the parent pom, and then make jboss.home default to the value of jboss.dist in the arquillian poms. That way for the use case where the configuration and binaries are in the same location, there is only a single place to change the path.
> Replace jboss.dist with jboss.home for testsuite and other usage
> ----------------------------------------------------------------
>
> Key: AS7-3987
> URL: https://issues.jboss.org/browse/AS7-3987
> Project: Application Server 7
> Issue Type: Enhancement
> Components: Build System, Test Suite
> Reporter: Paul Gier
> Assignee: Ondrej Zizka
> Fix For: 7.1.3.Final (EAP)
>
>
> Currently the testsuite uses a combination of the properties jboss.dist and jboss.home to represent the path to the as7 dist directory. I don't know of any situations where these two properties would be set to different values, so we can probably remove usage of jboss.dist and just use jboss.home everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jboss-jira
mailing list