[jboss-jira] [JBoss JIRA] (AS7-355) Store config file comments in the model

Tue Jul 31 22:32:07 EDT 2012

    [ https://issues.jboss.org/browse/AS7-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709046#comment-12709046 ] 

Brian Stansberry commented on AS7-355:
--------------------------------------

(Note, I'm on holidays, so will be slow to respond for a few days).

This is a big task. I think it needs significant discussion on the jboss-as7-dev list. We need to figure out where in the model data structure we would store the comments. 

For AS 7.x the default behavior would have to be that a given xml element doesn't support storing comments in the model, as the various parsers/marshallers we have will not automagically support this. This includes parsers/marshallers for subsystems that aren't part of the AS7 project itself, where it's not possible for us to update them to use the new capability.

To get a better understanding of how staxmapper is used in AS7 domain management, see

https://github.com/jbossas/jboss-as/blob/95380b67eb8023a406780f72ad17a747be879dd8/controller/src/main/java/org/jboss/as/controller/persistence/AbstractConfigurationPersister.java#L89

The parsing and marshalling classes for the AS core namespace (i.e. not subsystems) is in

https://github.com/jbossas/jboss-as/blob/95380b67eb8023a406780f72ad17a747be879dd8/host-controller/src/main/java/org/jboss/as/host/controller/parsing/DomainXml.java
https://github.com/jbossas/jboss-as/blob/95380b67eb8023a406780f72ad17a747be879dd8/host-controller/src/main/java/org/jboss/as/host/controller/parsing/HostXml.java
https://github.com/jbossas/jboss-as/blob/95380b67eb8023a406780f72ad17a747be879dd8/server/src/main/java/org/jboss/as/server/parsing/StandaloneXml.java

The ManagementXml class you linked is delegated to by the above; it just encapsulates some common logic used by the above.

Each subsystem will also have it's own parsers and marshallers for it's namespace.

> Store config file comments in the model
> ---------------------------------------
>
>                 Key: AS7-355
>                 URL: https://issues.jboss.org/browse/AS7-355
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: Domain Management
>            Reporter: Brian Stansberry
>             Fix For: Open To Community
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira