[jboss-jira] [JBoss JIRA] (AS7-3940) bundled jsf deployment fails when org.jboss.jbossfaces.WAR_BUNDLES_JSF_IMPL true

[Stuart Douglas (JIRA)]

    [ https://issues.jboss.org/browse/AS7-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704062#comment-12704062 ] 

Stuart Douglas commented on AS7-3940:
-------------------------------------

I have submitted a PR that breaks JSF off into its own subsystem. When the version is set to WAR_BUNDLES_JSF_IMPL no JSF classes or META-INF/services entries should be exposed to the deployment. 

This means it is now possible to completely remove JSF from the configuration, or exlucde it via jboss-deployment-structure.xml:

{code|XML}
<jboss-deployment-structure xmlns="urn:jboss:deployment-structure:1.2">
    <deployment>
        <exclude-subsystems>
            <subsystem name="ejb3" />
        </exclude-subsystems>
    </deployment>
</jboss-deployment-structure>
{code}

This also opens the possibility of providing a myfaces subsystem (probably as a 3rd party project) that will allow people to use myfaces with full container integration. 
                
> bundled jsf deployment fails when org.jboss.jbossfaces.WAR_BUNDLES_JSF_IMPL true
> --------------------------------------------------------------------------------
>
>                 Key: AS7-3940
>                 URL: https://issues.jboss.org/browse/AS7-3940
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: JSF
>    Affects Versions: 7.1.0.Final
>            Reporter: Juergen Hoffmann
>            Assignee: Stuart Douglas
>             Fix For: Open To Community
>
>
> It is impossible for Applications to bundle their own JSF Implementations even with org.jboss.jbossfaces.WAR_BUNDLES_JSF_IMPL defined in web.xml, because jboss-as-web provides META-INF/services/com.sun.faces.spi.annotationprovider and injectionprovider please see https://github.com/jbossas/jboss-as/tree/master/web/src/main/resources/META-INF/services and therefor will always try to use the JandexAnnotationProvider, which cannot work on different JSF Versions
> 12:29:30,105 SCHWERWIEGEND [javax.enterprise.resource.webcontainer.jsf.config] (MSC service thread 1-8) Critical error during deployment: : com.sun.faces.config.ConfigurationException: CONFIGURATION FAILED! Class org.jboss.as.web.deployment.jsf.JandexAnnotationProvider is not an instance of com.sun.faces.spi.AnnotationProvider

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira