[jboss-jira] [JBoss JIRA] (AS7-3993) Fix up generation of IPv6-ready configs for IPv6 testing

[Ondrej Zizka (JIRA)]

    [ https://issues.jboss.org/browse/AS7-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673722#comment-12673722 ] 

Ondrej Zizka edited comment on AS7-3993 at 3/5/12 1:43 PM:
-----------------------------------------------------------

Brian:
{quote}
The way the AS code works should be fine.

The expression parser proceeds character by character from left to 
right. Once it enters an expression (i.e. sees '$' followed by '\{') it 
treats the first ':' as delimiting the system property from the default 
and it is not considered to be part of the default. Thereafter as it 
parses the default, it pays no particular attention to any character 
until it sees '}'.

https://github.com/jbossas/jboss-dmr/blob/master/src/main/java/org/jboss/dmr/ExpressionValue.java#L163

Recommending that people add a special delimiter sounds like something 
that will introduce bugs, since it requires any code that may want to 
read the value to deal with the []. That said, I think in practice if 
people do use ${jboss.bind.address:[::1]} it will work fine, at least in 
the "interface" elements. The value ends up getting passed to 
InetAddress.getByName() which will handle the [] just fine.
{quote}


                
      was (Author: ozizka):
    Brian:
{quote}
The way the AS code works should be fine.

The expression parser proceeds character by character from left to 
right. Once it enters an expression (i.e. sees '$' followed by '{') it 
treats the first ':' as delimiting the system property from the default 
and it is not considered to be part of the default. Thereafter as it 
parses the default, it pays no particular attention to any character 
until it sees '}'.

https://github.com/jbossas/jboss-dmr/blob/master/src/main/java/org/jboss/dmr/ExpressionValue.java#L163

Recommending that people add a special delimiter sounds like something 
that will introduce bugs, since it requires any code that may want to 
read the value to deal with the []. That said, I think in practice if 
people do use ${jboss.bind.address:[::1]} it will work fine, at least in 
the "interface" elements. The value ends up getting passed to 
InetAddress.getByName() which will handle the [] just fine.
{quote}


                  
> Fix up generation of IPv6-ready configs for IPv6 testing
> --------------------------------------------------------
>
>                 Key: AS7-3993
>                 URL: https://issues.jboss.org/browse/AS7-3993
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 7.1.0.Final
>            Reporter: Richard Achmatowicz
>            Assignee: Ondrej Zizka
>            Priority: Critical
>             Fix For: 7.1.1.Final
>
>
> The testsuite uses a combination of:
> - the ant script clustering-build.xml, with target build-clustering-udp
> - the ant script common-targets.xml, with target ts.config-as.ip-with-multicast and
> - the XSLT script changeIAddresses.xsl 
> to set up IPv6 addresses for testing multi-node tests.
> There are several problems:
> - the XSLT script is broken and does not change the multicast addresses
> - a number of multicast addresses are not receiving IPv6 defaults/overrides; in particular, we have the following required overrides:
> UDP JGroups stack multicast requirements: 
> -- socket-binding jgroups-udp: no IPv6 multicast address assigned, due to broken changeIPAddresses.xml   
> -- socket-binding jgroups-diagnostics: no IPv6 multicast address assigned, due to no parameter passed in ts.config-as.ip-with-multicast  
> TCP JGroups stack multicast-requirements:
> -- socket-binding jgroups-mping: no IPv6 multicast address assigned, due to no parameter passed in ts.config-as.ip-with-multicast   
> -- socket-binding jgroups-diagnostics: no IPv6 multicast address assigned, due to no parameter passed in ts.config-as.ip-with-multicast  
> mosdcluster multicast-requirements:    
> -- socket-binding modcluster: no IPv6 multicast address assigned, due to no parameter passed in ts.config-as.ip-with-multicast 
> This results in server configurations which are not correctly configured for testing against IPv6 addresses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira