[jboss-jira] [JBoss JIRA] (AS7-1893) JDBC cache store configuration improvements

Tue Mar 13 10:19:47 EDT 2012

    [ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676430#comment-12676430 ] 

Martin Gencur commented on AS7-1893:
------------------------------------

One more thing.. I'm looking at https://github.com/rachmatowicz/jboss-as/commit/9fed5aad5faacde351966d15f117b04ebf16b896#L0R589 and https://github.com/rachmatowicz/jboss-as/commit/9fed5aad5faacde351966d15f117b04ebf16b896#L1R539 and I see a problem.

When we have XSD types for all three jdbc cache stores (string-keyed-jdbc-store, binary-keyed-jdbc-store and mixed-keyed-jdbc-store), I would suppose that when I use mixed-keyed-jdbc-store, I can really only create mixed jdbc cache store from it. However, from the code logic it seems that when a user specifies mixed-keyed-jdbc-store and inside that only binary-keyed-table, they will actually get binary jdbc cache store (the same for string-based one when they specify only string-keyed-table).

I would suppose here that the XSD will say that binary-keyed-table has minOccurs=1 and maxOccurs=1 as well as string-keyed-table (they have "0" now): https://github.com/rachmatowicz/jboss-as/blob/9fed5aad5faacde351966d15f117b04ebf16b896/build/src/main/resources/docs/schema/jboss-as-infinispan_1_2.xsd#L589 

WDYT?

> JDBC cache store configuration improvements
> -------------------------------------------
>
>                 Key: AS7-1893
>                 URL: https://issues.jboss.org/browse/AS7-1893
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: Clustering
>            Reporter: Manik Surtani
>            Assignee: Richard Achmatowicz
>             Fix For: 7.1.1.Final
>
>
> The current <jdbc-store ...> element isn't quite explicit enough to differentiate between the 3 types of JDBC cache stores Infinispan has to offer.  <string-keyed-jdbc-store ... >, <binary-keyed-jdbc-store ... > and <mixed-keyed-jdbc-store ... > may be better.  Similarly, <bucket-table> and <entry-table> expose implementation details. <binary-keyed-table ...> and <string-keyed-table ... > may be better.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira