[jboss-jira] [JBoss JIRA] (JGRP-1438) GMS shouldn't bundle requests that can't be processed together

[Bela Ban (JIRA)]

     [ https://issues.jboss.org/browse/JGRP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bela Ban updated JGRP-1438:
---------------------------

      Fix Version/s: 3.1
        Description: 

GMS's Requests are divided into two categories:
1/ Can Be Processed Together (CBPT): JOIN, LEAVE and SUSPECT
2 Can Not Be Processed Together (CNBPT) : MERGE and JOIN_WITH_STATE_TRANSFER

Bundling concerns only CBPT requests. So when a CNBPT request is received, it should be processed immediately.

Currently, a MERGE request is postponed due to bundling instead of being executed immediately. Two conditions to unblock it:

- Timeout expiration.

- Receiving another message. Note that whatever the following message is, it can't be processed with CBPT message

Expected behavior: Treating immediately CNBPT requests

A simple solution: Bring a light modification to method GMS.ViewHandler.run() at line 1333
-------------
if(wait_time > 0)

becomes :

if(wait_time > 0 && firstRequest.canBeProcessedTogether(firstRequest))
-------------

Note that if a request can't be processed with a request of the same type => it coudn't be processed with any other request type

  was:


GMS's Requests are divided into two categories:
1/ Can Be Processed Together (CBPT): JOIN, LEAVE and SUSPECT
2 Can Not Be Processed Together (CNBPT) : MERGE and JOIN_WITH_STATE_TRANSFER

Bundling concerns only CBPT requests. So when a CNBPT request is received, it should be processed immediately.

Currently, a MERGE request is postponed due to bundling instead of being executed immediately. Two conditions to unblock it:

- Timeout expiration.

- Receiving another message. Note that whatever the following message is, it can't be processed with CBPT message

Expected behavior: Treating immediately CNBPT requests

A simple solution: Bring a light modification to method GMS.ViewHandler.run() at line 1333
-------------
if(wait_time > 0)

becomes :

if(wait_time > 0 && firstRequest.canBeProcessedTogether(firstRequest))
-------------

Note that if a request can't be processed with a request of the same type => it coudn't be processed with any other request type

    Forum Reference: http://sourceforge.net/mailarchive/forum.php?thread_name=CAGvoXuqxf-pHLb%2BXziHM6K1MzdW-nJqdbm%3D51fz_NR2F__hA-A%40mail.gmail.com&forum_name=javagroups-users  (was: http://sourceforge.net/mailarchive/forum.php?thread_name=CAGvoXuqxf-pHLb%2BXziHM6K1MzdW-nJqdbm%3D51fz_NR2F__hA-A%40mail.gmail.com&forum_name=javagroups-users)


Might get pushed into 3.2
                
> GMS shouldn't bundle requests that can't be processed together 
> ---------------------------------------------------------------
>
>                 Key: JGRP-1438
>                 URL: https://issues.jboss.org/browse/JGRP-1438
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.1
>            Reporter: Benoit Leblanc
>            Assignee: Bela Ban
>            Priority: Minor
>             Fix For: 3.1
>
>
> GMS's Requests are divided into two categories:
> 1/ Can Be Processed Together (CBPT): JOIN, LEAVE and SUSPECT
> 2 Can Not Be Processed Together (CNBPT) : MERGE and JOIN_WITH_STATE_TRANSFER
> Bundling concerns only CBPT requests. So when a CNBPT request is received, it should be processed immediately.
> Currently, a MERGE request is postponed due to bundling instead of being executed immediately. Two conditions to unblock it:
> - Timeout expiration.
> - Receiving another message. Note that whatever the following message is, it can't be processed with CBPT message
> Expected behavior: Treating immediately CNBPT requests
> A simple solution: Bring a light modification to method GMS.ViewHandler.run() at line 1333
> -------------
> if(wait_time > 0)
> becomes :
> if(wait_time > 0 && firstRequest.canBeProcessedTogether(firstRequest))
> -------------
> Note that if a request can't be processed with a request of the same type => it coudn't be processed with any other request type

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira