[jboss-jira] [JBoss JIRA] (AS7-1735) Console: failure when creating new JMS should provide more information

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/AS7-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679335#comment-12679335 ] 

Brian Stansberry commented on AS7-1735:
---------------------------------------

The messaging subsystem should attach the cause to the StartException and not log it itself (i.e. the typical rule of "log or throw, but not both".) There's a separate JIRA for how the management layer is mining the StartException to prepare the DMR failure message. So, if the messaging subsystem is attaching the cause to the StartException and not logging it, it's doing it's job.
                
> Console: failure when creating new JMS should provide more information
> ----------------------------------------------------------------------
>
>                 Key: AS7-1735
>                 URL: https://issues.jboss.org/browse/AS7-1735
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: Domain Management, JMS
>    Affects Versions: 7.0.1.Final
>            Reporter: Radoslav Husar
>            Assignee: Jeff Mesnil
>              Labels: eap6-ux
>             Fix For: 7.1.2.Final
>
>
> Say I try to create a queue, but input incorrect values, the console provides the following which is not enough to know what was the root cause:
> {code}
> Tue Sep 06 12:52:33 GMT+200 2011
> Failed to create queue
> Unexpected HTTP response: 500
> Request
> {
>     "operation" => "add",
>     "address" => [
>         ("profile" => "default"),
>         ("subsystem" => "messaging"),
>         ("jms-queue" => "asdas")
>     ],
>     "entries" => ["dasdasd"],
>     "durable" => false,
>     "selector" => "*"
> }
> Response
> Internal Server Error
> {
>     "outcome" => "failed",
>     "result" => {"server-groups" => [("main-server-group" => {"master" => {
>     "host" => "master",
>     "response" => {
>         "outcome" => "failed",
>         "failure-description" => {"Failed services" => {"jboss.messaging.jms.queue.asdas" => "org.jboss.msc.service.StartException in service jboss.messaging.jms.queue.asdas: failed to create queue"}},
>         "rolled-back" => true
>     }
> }})]},
>     "failure-description" => "Operation failed or was rolled back on all servers.",
>     "rolled-back" => true
> }
> {code}
> while the server says:
> {code}
> [Server:server-one] 12:52:33,840 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-3) MSC00001: Failed to start service jboss.messaging.jms.queue.asdas: org.jboss.msc.service.StartException in service jboss.messaging.jms.queue.asdas: failed to create queue
> [Server:server-one] 	at org.jboss.as.messaging.jms.JMSQueueService.start(JMSQueueService.java:60)
> [Server:server-one] 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1765)
> [Server:server-one] 	at org.jboss.msc.service.ServiceControllerImpl$ClearTCCLTask.run(ServiceControllerImpl.java:2291)
> [Server:server-one] 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [:1.6.0_26]
> [Server:server-one] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [:1.6.0_26]
> [Server:server-one] 	at java.lang.Thread.run(Thread.java:662) [:1.6.0_26]
> [Server:server-one] Caused by: HornetQException[errorCode=103 message=Invalid filter: * Encountered "*" at line 1, column 1.
> [Server:server-one] Was expecting one of:
> [Server:server-one]     "TRUE" ...
> [Server:server-one]     "FALSE" ...
> [Server:server-one]     "NOT" ...
> [Server:server-one]     "(" ...
> [Server:server-one]     "-" ...
> [Server:server-one]     "+" ...
> [Server:server-one]     <INTEGER_LITERAL> ...
> [Server:server-one]     <FLOATING_POINT_LITERAL> ...
> [Server:server-one]     <SIMPLE_STRING> ...
> [Server:server-one]     <IDENTIFIER> ...
> [Server:server-one]     ]
> [Server:server-one] 	at org.hornetq.core.filter.impl.FilterImpl.<init>(FilterImpl.java:117)
> [Server:server-one] 	at org.hornetq.core.filter.impl.FilterImpl.createFilter(FilterImpl.java:97)
> [Server:server-one] 	at org.hornetq.core.server.impl.HornetQServerImpl.createQueue(HornetQServerImpl.java:1694)
> [Server:server-one] 	at org.hornetq.core.server.impl.HornetQServerImpl.deployQueue(HornetQServerImpl.java:1060)
> [Server:server-one] 	at org.hornetq.jms.server.impl.JMSServerManagerImpl.internalCreateQueue(JMSServerManagerImpl.java:1046)
> [Server:server-one] 	at org.hornetq.jms.server.impl.JMSServerManagerImpl.access$100(JMSServerManagerImpl.java:98)
> [Server:server-one] 	at org.hornetq.jms.server.impl.JMSServerManagerImpl$1.runException(JMSServerManagerImpl.java:422)
> [Server:server-one] 	at org.hornetq.jms.server.impl.JMSServerManagerImpl.runAfterActive(JMSServerManagerImpl.java:1643)
> [Server:server-one] 	at org.hornetq.jms.server.impl.JMSServerManagerImpl.createQueue(JMSServerManagerImpl.java:413)
> [Server:server-one] 	at org.jboss.as.messaging.jms.JMSQueueService.start(JMSQueueService.java:58)
> [Server:server-one] 	... 5 more
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira