[jboss-jira] [JBoss JIRA] (AS7-4198) default value in infinispan subsystem schema is ignored
Michal Linhard (JIRA)
jira-events at lists.jboss.org
Tue Mar 27 04:10:54 EDT 2012
[ https://issues.jboss.org/browse/AS7-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679531#comment-12679531 ]
Michal Linhard commented on AS7-4198:
-------------------------------------
I know that XSD is not parsed for default values, and that's the point of this JIRA.
And not even the code: https://github.com/jbossas/jboss-as/blob/master/clustering/infinispan/src/main/java/org/jboss/as/clustering/infinispan/subsystem/CommonAttributes.java#L196
determines the final outcome of whether L1 is or is not enabled. Because it is only activated when the attribute is _present_. (see the parsing logic)
Yes the question is whether we want L1 in ALL caches by default or not. (not some specific ones, it's not relevant to this issue)
My opinion is: NO, but that's of course open to a debate.
If we choose the default "L1 is NOT enabled" then we should IMO change the values both in schema and the code to 0, so that they don't confuse people.
I agree that the name of this JIRA is not optimal. Default value from schema being ignored is an expected thing.
> default value in infinispan subsystem schema is ignored
> -------------------------------------------------------
>
> Key: AS7-4198
> URL: https://issues.jboss.org/browse/AS7-4198
> Project: Application Server 7
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 7.1.1.Final
> Reporter: Michal Linhard
> Assignee: Paul Ferraro
> Priority: Minor
>
> Because of the way the infinispan subsystem is parsed:
> https://github.com/jbossas/jboss-as/blob/master/clustering/infinispan/src/main/java/org/jboss/as/clustering/infinispan/subsystem/InfinispanSubsystemXMLReader_1_1.java#L297
> The default value for l1-lifespan attribute specified here:
> https://github.com/jbossas/jboss-as/blob/master/build/src/main/resources/docs/schema/jboss-as-infinispan_1_1.xsd#L400
> is ignored.
> Could we changed it to zero in the schema, so that there aren't doubts whether L1 is or is not enabled by default when this attribute is omitted ?
> Correct behaviour IMO should be: L1 is disabled by default.
> And that is the way it is, this default value just adds to confusion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jboss-jira
mailing list